Re: pkg/53319: text relocations fixes for multimedia/mplayer andothers

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

The following reply was made to PR pkg/53319; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: wiz%NetBSD.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: pkg/53319: text relocations fixes for multimedia/mplayer andothers
Date: Sun, 27 May 2018 20:43:38 +0900

 wiz@ wrote:
 
 >  These are fine to commit, except for this chunk:
  :
 >  > --- mplayer-share/Makefile.depends	5 Mar 2016 09:03:02 -0000	1.21
 >  > +++ mplayer-share/Makefile.depends	27 May 2018 04:09:19 -0000
 >  > @@ -7,4 +7,5 @@ DEPENDS+=	mplayer-share>=${MPLAYER_VERSI
 >  >  .include "../../fonts/fontconfig/buildlink3.mk"
 >  >  .include "../../graphics/freetype2/buildlink3.mk"
 >  >  .include "../../multimedia/ffmpeg3/buildlink3.mk"
 >  > +.include "../../multimedia/libass/buildlink3.mk"
 >  >  .include "../../x11/libX11/buildlink3.mk"
 >  
 >  That should be a separate commit, or perhaps an additional
 >  (default-on?) option.
 
 The problematic source which has non-PIE asm inside HAVE_SSE4_INTERNAL
 is MPlayer-1.3.0/libmpcodecs/vf_ass.c. It is complied only if the ASS
 is enabled by the configure.
 
 mplayer's configure has the following options:
 >  --enable-ass-internal  enable internal SSA/ASS subtitle support [autodetect]
 >  --disable-ass          disable SSA/ASS subtitle support [autodetect]
 so ASS support is "autodetect"-ed.
 
 It looks "ass-internal" is selected by default if the system has
 freetype 2.2.1 or newer (and pkgsrc/multimedia/libass/buildlink3.mk
 is not specified), according to the configure script.
 
 mplayer-share/Makefile.depends also includes
 graphics/freetype2/buildlink3.mk and it requires 2.4.11:
 > BUILDLINK_ABI_DEPENDS.freetype2+=       freetype2>=2.4.11
 so I think ASS support is enabled (by autodetect) in usual cases.
 
 I have not checked if mplayer's internal libass sources have
 any other non-PIE code (there is no obvious "asm" keyword though),
 but pkgsrc/multimedia/libass/Makefile already has the following line
 > CONFIGURE_ARGS+=	--disable-asm
 so it's safer to use it explicitly.
 
 Anyway, I won't bother to add a new option for mplayer's libass
 because there was no explict way to disable it in the past
 (and there are so many other "autodetect" options).
 
 I'll commit the mplayer-share's libass change (and each
 multimedia package) separately, but ride on PKGREVISION bump
 of the text reloc changes for mplayer and mencoder.
 
 Thanks,
 ---
 Izumi Tsutsui