Re: pkg/53269 (lang/nodejs8 compilation fails)

[Mayuresh <mayuresh%acm.org@localhost>]

The following reply was made to PR pkg/53269; it has been noted by GNATS.

From: Mayuresh <mayuresh%acm.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: fhajny%NetBSD.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost
Subject: Re: pkg/53269 (lang/nodejs8 compilation fails)
Date: Fri, 11 May 2018 07:03:30 +0530

 Confirm that the compilation goes through after applying this patch.
 
 Mayuresh.
 
 On Wed, May 09, 2018 at 04:35:01PM +0000, Leonardo Taccari wrote:
 > The following reply was made to PR pkg/53269; it has been noted by GNATS.
 > 
 > From: Leonardo Taccari <leot%NetBSD.org@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc: 
 > Subject: Re: pkg/53269 (lang/nodejs8 compilation fails)
 > Date: Wed, 09 May 2018 18:23:40 +0200
 > 
 >  Hello Mayuresh,
 >  
 >  Mayuresh writes:
 >  > I am using git and did a pull after your mail. Not sure whether the
 >  > patches you mentioned are in:
 >  >
 >  > Last log is:
 >  >
 >  > # git log distinfo =
 >  
 >  > commit 422ebd2f16d41eb848cb240a081d3ef6bc71c55d (grafted)
 >  > Author: manu <manu%pkgsrc.org@localhost>
 >  > Date:   Wed May 9 12:23:39 2018 +0000
 >  >
 >  >     Added www/htdavlcok 0.2
 >  >     =
 >  
 >  >     This is an Apache mod_davv_fs lock database management tool.
 >  >     =
 >  
 >  >     Sometimes a program crashes, leaving stale a lock on a WebDAV-based =
 >  file.
 >  >     This tool can inspect the lock database, and remove a stale lock.
 >  >     =
 >  
 >  >     The alternative is to wait for lock expiration.
 >  
 >  Yes, this should contain the icu fixes.
 >  
 >  > I still get the following error (not checked whether same or different a=
 >  s
 >  > before):
 >  >
 >  >
 >  > In file included from ../src/node_crypto.cc:41:0:
 >  > ../src/node_crypto.cc: In function 'void node::crypto::PBKDF2(const
 >  > v8::FunctionCallbackInfo<v8::Value>&)':
 >  > ../src/node_crypto.cc:5510:32: error: expected unqualified-id before '('
 >  > token
 >  >    if (raw_keylen < 0.0 || std::isnan(raw_keylen) ||
 >  > std::isinf(raw_keylen) ||
 >  >                                 ^
 >  > ../src/node_crypto.cc:5510:58: error: expected unqualified-id before '('
 >  > token
 >  >    if (raw_keylen < 0.0 || std::isnan(raw_keylen) ||
 >  > std::isinf(raw_keylen) ||
 >  >                                                           ^
 >  > node.target.mk:178: recipe for target
 >  > '/usr/pkgsrc/lang/nodejs8/work/node-v8.11.1/out/Release/obj.target/node/=
 >  src/node_crypto.o'
 >  > failed
 >  > gmake[1]: ***
 >  > [/usr/pkgsrc/lang/nodejs8/work/node-v8.11.1/out/Release/obj.target/node/=
 >  src/node_crypto.o]
 >  > Error 1
 >  >
 >  
 >  Different problem. Can you please try the following patch (WARNING:
 >  I have not tested that but according the discussion upstream I
 >  think it should fix this issue):
 >  
 >   https://NetBSD.org/~leot/pkgsrc-patches/nodejs8-8.11.1nb2-cmath.patch
 >  
 >  
 >  Please let us know if that fixes the issue!
 >