Re: pkg/53112: glib-mkenums fails with xfce4 source files

[Patrick Welche <prlw1%cam.ac.uk@localhost>]

The following reply was made to PR pkg/53112; it has been noted by GNATS.

From: Patrick Welche <prlw1%cam.ac.uk@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/53112: glib-mkenums fails with xfce4 source files
Date: Wed, 21 Mar 2018 17:41:10 +0000

 On Tue, Mar 20, 2018 at 10:50:00AM +0000, martin%NetBSD.org@localhost wrote:
 > Didn't we fix this already in the past?
 
 I thought I had fixed it with
 
 ----------------------------
 revision 1.225
 date: 2017-10-21 09:57:33 +0100;  author: prlw1;  state: Exp;  lines: +2 -2;  commitid: KUtdiNm0VP94HTbA;
 glib2-tools: Handle source files which are not utf-8
 
 python 3 is strict about file encodings. After glib-mkenums was
 translated from perl to python, build failures occur due to e.g.,
 ISO-8859-1 characters in authors' names as reported by martin@ in
 PR pkg/52631 for xfce4-gtk2-engines, but also causing build failures
 for at least libgnome and libgnomeui.
 
 Chritoph Reiter produced an elegant workaround, making use of the
 open() function's error decoding "replace" option:
 
   'replace' causes a replacement marker (such as '?') to be inserted
   where there is malformed data.
 
 which is applied here.
 
 https://bugzilla.gnome.org/show_bug.cgi?id=785113#c27
 ----------------------------
 
 and even got it in upstream:
 
 ----------------------------
 revision 1.61
 date: 2018-01-28 16:51:50 +0000;  author: wiz;  state: Exp;  lines: +2 -2;  commitid: BO5umQds80rBbFoA;
 glib2: update to 2.54.3.
 
 Overview of changes in GLib 2.54.3
 ==================================
 
 * Bugs fixed:
 ...
  785113 glib-mkenums Python port fixes