pkg/53115: pkgtools/x11-links mishandles xf86dga libs

[dholland%eecs.harvard.edu@localhost]

>Number:         53115
>Category:       pkg
>Synopsis:       pkgtools/x11-links mishandles xf86dga libs
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 20 20:30:00 +0000 2018
>Originator:     David A. Holland
>Release:        NetBSD 8.99.9, pkgsrc 20180320
>Organization:
>Environment:
System: NetBSD macaran 8.99.9 NetBSD 8.99.9 (MACARAN) #46: Sun Jan 21 21:26:19 EST 2018 dholland@macaran:/usr/src/sys/arch/amd64/compile/MACARAN amd64
Architecture: x86_64
Machine: amd64
>Description:

x11-links is now (probably after the xorgproto changes) linking the
headers but not the libraries for libXxf86dga.

This makes some old games (e.g. tyrquake) not build.

>How-To-Repeat:

>Fix:

This seems to make it work for me, but may or may not be correct
(I have never fully understood the x11-links logic)

Index: files/xorg
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/x11-links/files/xorg,v
retrieving revision 1.25
diff -u -r1.25 xorg
--- files/xorg	27 Dec 2015 18:56:33 -0000	1.25
+++ files/xorg	20 Mar 2018 20:23:19 -0000
@@ -452,6 +452,15 @@
 lib/libXvMCW.so.1
 lib/libXvMCW.so.1.0
 lib/libXvMCW.so.2.0
+lib/libXxf86dga.a
+lib/libXxf86dga.la
+lib/libXxf86dga.so
+lib/libXxf86dga.so.1
+lib/libXxf86dga.so.1.0
+lib/libXxf86dga.so.1.1
+lib/libXxf86dga.so.2
+lib/libXxf86dga.so.2.0
+lib/libXxf86dga.so.5.0
 lib/libXxf86misc.1.1.0.dylib
 lib/libXxf86misc.1.dylib
 lib/libXxf86misc.dylib
Index: files/xorg.xf86dgaproto
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/x11-links/files/xorg.xf86dgaproto,v
retrieving revision 1.5
diff -u -r1.5 xorg.xf86dgaproto
--- files/xorg.xf86dgaproto	7 Mar 2014 15:27:32 -0000	1.5
+++ files/xorg.xf86dgaproto	20 Mar 2018 20:23:19 -0000
@@ -9,15 +9,6 @@
 include/X11/extensions/xf86dgaconst.h
 include/X11/extensions/xf86dgaproto.h
 include/X11/extensions/xf86dgastr.h
-lib/libXxf86dga.a
-lib/libXxf86dga.la
-lib/libXxf86dga.so
-lib/libXxf86dga.so.1
-lib/libXxf86dga.so.1.0
-lib/libXxf86dga.so.1.1
-lib/libXxf86dga.so.2
-lib/libXxf86dga.so.2.0
-lib/libXxf86dga.so.5.0
 lib/pkgconfig/xf86dgaproto.pc
 lib/pkgconfig/xxf86dga.pc
 share/pkgconfig/xf86dgaproto.pc