pkg/53100: www/firefox fails to build on netbsd-7

[scole_mail%gmx.com@localhost]

>Number:         53100
>Category:       pkg
>Synopsis:       www/firefox fails to build on netbsd-7
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Mar 15 15:25:00 +0000 2018
>Originator:     scole_mail
>Release:        pkgsrc-2017Q4
>Organization:
none
>Environment:
NetBSD dstar 7.1.1_PATCH NetBSD 7.1.1_PATCH (GENERIC) #0: Tue Feb 13 10:51:14 PST 2018  scole@dstar:/home/scole/nbsd/cvs/7_0/obj/sys/arch/i386/compile/GENERIC i386
>Description:
firefox fails build because of missing #define in netbsd-7

gmake[3]: Entering directory '/usr/pkgsrc/www/firefox/work/build/xpcom/io'
/usr/pkgsrc/www/firefox/work/.cwrapper/bin/c++ -std=gnu++11 -o Unified_cpp_xpcom_io0.o -c -I/usr/pkgsrc/www/firefox/work/build/dist/stl_wrappers -I/usr/pkgsrc/www/firefox/work/build/dist/system_wrappers -include /usr/pkgsrc/www/firefox/work/firefox-58.0/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_NETBSD=1 -DOS_BSD=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/usr/pkgsrc/www/firefox/work/firefox-58.0/xpcom/io -I/usr/pkgsrc/www/firefox/work/build/xpcom/io -I/usr/pkgsrc/www/firefox/work/build/ipc/ipdl/_ipdlheaders -I/usr/pkgsrc/www/firefox/work/firefox-58.0/ipc/chromium/src -I/usr/pkgsrc/www/firefox/work/firefox-58.0/ipc/glue -I/usr/pkgsrc/www/firefox/work/build/xpcom -I/usr/pkgsrc/www/firefox/work/firefox-58.0/xpcom/build -I/usr/pkgsrc/www/firefox/work/build/dist/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss -I/usr/pkg/include/nspr -I/usr/X11R7/include/pixman-1 -fPIC -DPIC -DMOZILLA_CLIENT -include /usr/pkgsrc/www/firef
 ox/work/build/mozilla-config.h -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -I/usr/pkg/include/ffmpeg3 -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -O2 -I/usr/pkg/include/nspr -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nss/nss -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -I/usr/pkg/include/ffmpeg3 -march=i586 -mstackrealign -fno-exceptions -fno-strict-aliasing -Dunix -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -I/usr/pkg/include -O2 -fomit-frame-pointer  -MD -MP -MF .deps/Unified_cpp_xpcom_io0.o.pp   /usr/pkgsrc/www/firefox/work/b
 uild/xpcom/io/Unified_cpp_xpcom_io0.cpp
In file included from /usr/pkgsrc/www/firefox/work/firefox-58.0/xpcom/io/nsDirectoryService.cpp:40:0,
                 from /usr/pkgsrc/www/firefox/work/build/xpcom/io/Unified_cpp_xpcom_io0.cpp:92:
/usr/pkgsrc/www/firefox/work/firefox-58.0/xpcom/build/BinaryPath.h: In static member function 'static nsresult mozilla::BinaryPath::Get(char*)':
/usr/pkgsrc/www/firefox/work/firefox-58.0/xpcom/build/BinaryPath.h:183:14: error: 'KERN_PROC_PATHNAME' was not declared in this scope
     mib[3] = KERN_PROC_PATHNAME;
              ^
/usr/pkgsrc/www/firefox/work/firefox-58.0/config/rules.mk:1028: recipe for target 'Unified_cpp_xpcom_io0.o' failed
gmake[3]: *** [Unified_cpp_xpcom_io0.o] Error 1
gmake[3]: Leaving directory '/usr/pkgsrc/www/firefox/work/build/xpcom/io'
/usr/pkgsrc/www/firefox/work/firefox-58.0/config/recurse.mk:73: recipe for target 'xpcom/io/target' failed
gmake[2]: *** [xpcom/io/target] Error 2
gmake[2]: Leaving directory '/usr/pkgsrc/www/firefox/work/build'
/usr/pkgsrc/www/firefox/work/firefox-58.0/config/recurse.mk:32: recipe for target 'compile' failed
gmake[1]: *** [compile] Error 2
gmake[1]: Leaving directory '/usr/pkgsrc/www/firefox/work/build'
/usr/pkgsrc/www/firefox/work/firefox-58.0/config/rules.mk:432: recipe for target 'all' failed
gmake: *** [all] Error 2
*** Error code 2

Stop.
bmake[1]: stopped in /usr/pkgsrc/www/firefox
*** Error code 1

Stop.
bmake: stopped in /usr/pkgsrc/www/firefox

>How-To-Repeat:
cd .../pkgsrc/www/firefox && bmake

>Fix:
Add KERN_PROC_PATHNAME somewhere if <= netbsd-7

It exists in current in 
https://nxr.netbsd.org/xref/src/sys/sys/sysctl.h#680


#define	KERN_PROC_PATHNAME 	5	/* path to executable */