pkg/53021: databases/mariadb55-client from pkgsrc_2017Q4 fails to build with missing readline type declaration

[timshel%fluentdevelopment.com.au@localhost]

>Number:         53021
>Category:       pkg
>Synopsis:       databases/mariadb55-client from pkgsrc_2017Q4 fails to build due to missing readline type declaration
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 13 00:20:00 +0000 2018
>Originator:     Timshel Knoll-Miller <timshel%fluentdevelopment.com.au@localhost>
>Release:        NetBSD 7.1_STABLE
>Organization:
	Fluent Development
>Description:

The build fails with the follow error:
[ 92%] Building C object client/CMakeFiles/mysqlcheck.dir/mysqlcheck.c.o
[ 92%] Linking CXX executable mysqlcheck
[ 92%] Built target mysqlcheck
Scanning dependencies of target mysql
[ 93%] Building CXX object client/CMakeFiles/mysql.dir/completion_hash.cc.o
[ 93%] Building CXX object client/CMakeFiles/mysql.dir/mysql.cc.o
/tmp/work/databases/mariadb55-client/work/mariadb-5.5.57/client/mysql.cc: In function 'void initialize_readline(char*)':
/tmp/work/databases/mariadb55-client/work/mariadb-5.5.57/client/mysql.cc:2646:38: error: 'rl_completion_func_t' was not declared in this scope
   rl_attempted_completion_function= (rl_completion_func_t*)&new_mysql_completion;
                                      ^
/tmp/work/databases/mariadb55-client/work/mariadb-5.5.57/client/mysql.cc:2646:59: error: expected primary-expression before ')' token
   rl_attempted_completion_function= (rl_completion_func_t*)&new_mysql_completion;
                                                           ^
/tmp/work/databases/mariadb55-client/work/mariadb-5.5.57/client/mysql.cc:2647:31: warning: invalid conversion from 'char* (*)(const char*, int)' to 'int (*)(const char*, int)' [-fpermissive]
   rl_completion_entry_function= (rl_compentry_func_t*)&no_completion;
                               ^
/tmp/work/databases/mariadb55-client/work/mariadb-5.5.57/client/mysql.cc:2649:73: warning: invalid conversion from 'int (*)(int, int)' to 'int (*)(const char*, int)' [-fpermissive]
   rl_add_defun("magic-space", (rl_command_func_t *)&fake_magic_space, -1);
                                                                         ^
client/CMakeFiles/mysql.dir/build.make:86: recipe for target 'client/CMakeFiles/mysql.dir/mysql.cc.o' failed
gmake[2]: *** [client/CMakeFiles/mysql.dir/mysql.cc.o] Error 1
CMakeFiles/Makefile2:1780: recipe for target 'client/CMakeFiles/mysql.dir/all' failed
gmake[1]: *** [client/CMakeFiles/mysql.dir/all] Error 2
gmake[1]: *** Waiting for unfinished jobs....
[ 93%] Linking CXX executable mysqltest
[ 93%] Built target mysqltest
Makefile:151: recipe for target 'all' failed
gmake: *** [all] Error 2
*** Error code 2

Stop.
make[1]: stopped in /usr/pkgsrc/databases/mariadb55-client
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/databases/mariadb55-client

>How-To-Repeat:

Build package using builtin editline (no readline package installed):
Package build environment:
coliban /usr/pkgsrc/databases/mariadb55-client$ make show-var VARNAME=READLINE_TYPE
editline
coliban /usr/pkgsrc/databases/mariadb55-client$ make show-options
Any of the following general options may be selected:
        dtrace   Enable DTrace support.
        embedded-server  Enable embedded server support for MySQL.
        ndb-cluster      Build NDB Cluster support.
        sphinx   Enable Sphinx full-text search.
        ssl      Enable SSL support.

These options are enabled by default:
        embedded-server ssl

These options are currently enabled:
        embedded-server ssl

You can select which build options to use by setting PKG_DEFAULT_OPTIONS
or PKG_OPTIONS.mariadb55.
coliban /usr/pkgsrc/databases/mariadb55-client$ make package
...
<build fails>

I'm using a pbulk sandbox for the build so am not sure if that may be having an effect.

>Fix:

Unknown. In my search for a fix I found other users have had the same issue on both NetBSD 7.1 and NetBSD 6.0.
See the thread on the pkgsrc-changes mailing list:
https://mail-index.netbsd.org/pkgsrc-users/2017/05/01/msg024770.html

Reverting this change supposedly fixes the issue, so maybe something needs to be tweaked with the jk
http://mail-index.netbsd.org/pkgsrc-changes/2017/02/03/msg152418.html

>Unformatted:
 Built from sources on 2017-03-30
 System: NetBSD coliban.fluentdevelopment.com.au 7.1_STABLE NetBSD 7.1_STABLE (GENERIC) #0: Thu Mar 30 02:03:23 AEDT 2017 timshel@abalone.shels.local:/store/obj/sys/arch/amd64/compile/GENERIC amd64
 Architecture: x86_64
 Machine: amd64