pkg/52970: recent current pkgsrc: /usr/pkgsrc/geography/qgis fails to build

[dtyson%anduin.org.uk@localhost]

>Number:         52970
>Category:       pkg
>Synopsis:       recent current pkgsrc: /usr/pkgsrc/geography/qgis fails to build
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 31 10:05:00 +0000 2018
>Originator:     Dave Tyson
>Release:        NetBSD 8.0_BETA. pkgsrc current from around 27th Jan 2018
>Organization:
Anduin
>Environment:
NetBSD dell.anduin.org.uk 8.0_BETA NetBSD 8.0_BETA (GENERIC.201801221730Z) amd64
>Description:
Doing a make install results in a failure to find qjson as its buildlink is missing from the Makefile. When this is fixed it still fails to install as the PLIST is missing a couple of files added in this release.

Scanning dependencies of target arcgismapserverprovider [ 51%] Building CXX object src/providers/arcgisrest/CMakeFiles/arcgismapserverprovider.dir/qgsarcgisrestutils.cpp.o
/usr/pkgsrc/geography/qgis/work/qgis-2.18.3/src/providers/arcgisrest/qgsarcgisrestutils.cpp:36:26: fatal error: qjson/parser.h: No such file or directory
compilation terminated.
src/providers/arcgisrest/CMakeFiles/arcgismapserverprovider.dir/build.make:82: recipe for target 'src/providers/arcgisrest/CMakeFiles/arcgismapserverprovider.dir/qgsarcgisrestutils.cpp.o' failed
gmake[2]: *** [src/providers/arcgisrest/CMakeFiles/arcgismapserverprovider.dir/qgsarcgisrestutils.cpp.o] Error 1
CMakeFiles/Makefile2:1757: recipe for target 'src/providers/arcgisrest/CMakeFiles/arcgismapserverprovider.dir/all' failed
gmake[1]: *** [src/providers/arcgisrest/CMakeFiles/arcgismapserverprovider.dir/all] Error 2
Makefile:162: recipe for target 'all' failed
gmake: *** [all] Error 2
*** Error code 2


>How-To-Repeat:
cd /usr/pkgsrc/geography/qgis
make install
>Fix:
Update Makefile and PLIST in the top level directory:

--- Makefile.orig       
+++ Makefile    
@@ -65,5 +65,6 @@
 .include "../../x11/qt4-libs/buildlink3.mk"
 .include "../../x11/qwt-qt4/buildlink3.mk"
 .include "../../x11/qt4-qscintilla/buildlink3.mk"
+.include "../../devel/qjson/buildlink3.mk"
 .include "../../mk/pgsql.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"

--- PLIST.orig  2017-01-26 13:49:19.000000000 +0000
+++ PLIST       2018-01-31 09:42:30.557606591 +0000
@@ -720,6 +720,8 @@
 lib/libqgis_networkanalysis.so
 lib/libqgis_networkanalysis.so.${PKGVERSION}
 lib/qgis/crssync
+lib/qgis/plugins/libarcgisfeatureserverprovider.so
+lib/qgis/plugins/libarcgismapserverprovider.so
 lib/qgis/plugins/libbasicauthmethod.so
 lib/qgis/plugins/libcoordinatecaptureplugin.so
 lib/qgis/plugins/libdb2provider.so