pkg/52927: pkgsrc/net/samba does not compile with PKG_OPTIONS=-pam

[Harold%NetBSD.org@localhost,"Gutch <logix"@foobar.franken.de]

>Number:         52927
>Category:       pkg
>Synopsis:       pkgsrc/net/samba does not compile with PKG_OPTIONS=-pam
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 15 23:15:00 +0000 2018
>Originator:     Harold Gutch
>Release:        pkgsrc HEAD
>Organization:
>Environment:
NetBSD  7.1 NetBSD 7.1 (GENERIC.201703111743Z) amd64
>Description:
When building Samba with "pam" (the default), its configure script is invoked with "--with-pam --with-pam_smbpass --with-pammodulesdir=...".  However, when building with "-pam", configure is invoked with no special parameters regarding PAM.  Samba's configure then falls back to automatically detecting the existence of PAM libraries and behaving either as if "--with-pam" or "--without-pam" had been specified.  Thus, on systems with PAM, there is no difference between "pam" and "-pam" for the build stage.

However, when building with "-pam", a few files are removed from PLIST, in particular lib/security/pam_{smbpass,winbind}.${LIBEXT}.  Thus, "make package" complains about a discrepancy between the contents of destdir and PLIST:
[...]
ERROR: ************************************************************
ERROR: The following files are in /home/pkgbld/pkgsrc/net/samba/work/.destdir/home/a/pkgbut not in the PLIST:
ERROR:         /home/pkgbld/pkgsrc/net/samba/work/.destdir/home/pkgbld/pkg/lib/security/pam_smbpass.so
ERROR:         /home/pkgbld/pkgsrc/net/samba/work/.destdir/home/pkgbld/pkg/lib/security/pam_winbind.so 

*** Error code 1

>How-To-Repeat:
cd /usr/pkgsrc/net/samba
make package PKG_OPTIONS.samba=-pam
>Fix:
Make the package explicitly invoke configure with "--without-pam" when building with "-pam":

--- pkgsrc/net/samba/options.mk  12 Nov 2017 15:36:58 -0000      1.38
+++ pkgsrc/net/samba/options.mk  15 Jan 2018 23:34:38 -0000
@@ -117,6 +117,9 @@
 		${INSTALL_DATA} $${f} \
 			${DESTDIR}${PREFIX}/${EGDIR}/pam_smbpass/$${f}; \
 	done
+.else
+CONFIGURE_ARGS+=	--without-pam
+CONFIGURE_ARGS+=	--without-pam_smbpass
 .endif

 ###


(Note: "--without-pam" already is sufficient, I put in that second line for consistency/symmetry with the "--with-pam" arguments a few lines above).