pkg/52807: tigervnc: patch-unix_xserver117.patch problem

[you.kawasaki%gmail.com@localhost]

>Number:         52807
>Category:       pkg
>Synopsis:       tigervnc: patch-unix_xserver117.patch problem
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 10 17:25:00 +0000 2017
>Originator:     Yosuke Kawasaki
>Release:        pkgsrc-2017Q3
>Organization:
YKK IP-Research
>Environment:
Linux xpc-debian 4.9.0-4-amd64 #1 SMP Debian 4.9.51-1 (2017-09-28) x86_64 GNU/Linux
>Description:

The compilation of TightVNC stopped with the following error

***
Making all in os
make[1]: Entering directory '/usr/pkg/obj/net/tigervnc/work/tigervnc-1.8.0/unix/xserver/os'
  CC       WaitFor.lo
In file included from WaitFor.c:58:0:
../include/dix-config.h:508:0: warning: "X_BYTE_ORDER" redefined
 #define X_BYTE_ORDER X_LITTLE_ENDIAN
 
In file included from /usr/pkg/obj/net/tigervnc/work/.buildlink/include/X11/Xos.h:146:0,
                 from /usr/pkg/obj/net/tigervnc/work/.buildlink/include/X11/Xpoll.h:66,
                 from WaitFor.c:55:
/usr/pkg/obj/net/tigervnc/work/.buildlink/include/X11/Xarch.h:88:0: note: this is the location of the previous definition
 #  define X_BYTE_ORDER BYTE_ORDER

***

It seems the problem is caused by patch-unix_xserver117.patch, which includes <X11/Xpoll.h> before <dix-config.h>


>How-To-Repeat:
make
>Fix:
change the order of inclusion so that <X11/Xpoll.h>  is included after <dix-config.h>