pkg/52651: lang/coq PLIST inaccuracies related to coqide

[tarik%sectopod.org@localhost]

>Number:         52651
>Category:       pkg
>Synopsis:       lang/coq PLIST inaccuracies related to coqide
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 24 16:05:00 +0000 2017
>Originator:     Aleksey Arens
>Release:        pkgsrc-2017Q3
>Organization:
>Environment:
NetBSD topsec 7.1 NetBSD 7.1 (GENERIC.201703111743Z) amd64
>Description:
The lang/coq package has an option to be built with IDE, which is enabled by setting "coqide" in PKG_OPTIONS.  When this option is disabled, the following issue occurs: (i) build succeeds, (ii) package creation files with the messages of being unable to stat the files.

The affected files are:

share/coq/coq-ssreflect.lang
share/coq/coq.lang
share/coq/coq.png
share/coq/coq_style.xml
share/doc/coq/FAQ-CoqIde

>How-To-Repeat:
Set PKG_OPTIONS.coq="-coqide" and attempt to build lang/coq.
>Fix:
After examining the coq's build directories and Makefiles, it was discovered that the files that cause an issue belong to the IDE.  Indeed, they reside under the ide/ subdirectory, and are only installed by makefiles when the configure option to build IDE is enabled.

Furthermore, it turns out that the files in question are listed in PLIST, but are not marked to be the part of PLIST.coqide.

The following change fixes the problem.

Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/lang/coq/PLIST,v
retrieving revision 1.21
diff -u -r1.21 PLIST
--- PLIST	8 Sep 2017 17:19:01 -0000	1.21
+++ PLIST	24 Oct 2017 15:36:22 -0000
@@ -4048,11 +4048,11 @@
 man/man1/coqtop.opt.1
 man/man1/coqwc.1
 man/man1/gallina.1
-share/coq/coq-ssreflect.lang
-share/coq/coq.lang
-share/coq/coq.png
-share/coq/coq_style.xml
-share/doc/coq/FAQ-CoqIde
+${PLIST.coqide}share/coq/coq-ssreflect.lang
+${PLIST.coqide}share/coq/coq.lang
+${PLIST.coqide}share/coq/coq.png
+${PLIST.coqide}share/coq/coq_style.xml
+${PLIST.coqide}share/doc/coq/FAQ-CoqIde
 ${PLIST.doc}share/doc/coq/LICENSE.doc
 ${PLIST.doc}share/doc/coq/html/RecTutorial.html
 ${PLIST.doc}share/doc/coq/html/Tutorial.html