pkg/52565: cinepaint build fails w/GCC on netbsd-8, -current

[jdbaker%mylinuxisp.com@localhost]

>Number:         52565
>Category:       pkg
>Synopsis:       cinepaint build fails w/GCC on netbsd-8, -current
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 22 05:15:00 +0000 2017
>Originator:     John D. Baker
>Release:        NetBSD/amd64-8.0_BETA, pkgsrc-HEAD (pre-pkgsrc-2017Q3)
>Organization:
>Environment:
NetBSD x3650.technoskunk.fur 8.0_BETA NetBSD 8.0_BETA (RACKMOUNT) #100: Tue Sep 19 17:17:03 CDT 2017  sysop%x3650.technoskunk.fur@localhost:/r1/build/netbsd-8/obj/amd64/sys/arch/amd64/compile/RACKMOUNT amd64

>Description:
Building "graphics/cinepaint" on netbsd-8 or -current w/GCC fails as
follows:

[...]
Making all in hdr
gmake[2]: Entering directory '/tmp/pkgsrc/graphics/cinepaint/work/cinepaint-0.22-1/plug-ins/hdr'
if gcc -DHAVE_CONFIG_H -I. -I. -I../../lib -I/usr/pkg/include  -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -I/usr/pkg/include/gtk-2.0 -I/usr/pkg/lib/gtk-2.0/include -I/usr/pkg/include/pango-1.0 -I/usr/pkg/include/glib/glib-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include -I/usr/pkg/include/cairo -I/usr/X11R7/include/pixman-1 -I/usr/X11R7/include -I/usr/X11R7/include/freetype2 -I/usr/pkg/include/libpng16 -I/usr/pkg/include/harfbuzz -I/usr/pkg/include/glib/gio-unix-2.0/ -D_REENTRANT -I/usr/pkg/include/gdk-pixbuf-2.0 -D_REENTRANT -I/usr/pkg/include/atk-1.0 -D_REENTRANT -pthread -pthread  -I/usr/pkg/include -I/usr/pkg/include/gtk-2.0 -I/usr/pkg/lib/gtk-2.0/include -I/usr/pkg/include/pango-1.0 -I/usr/pkg/include/glib/glib-2.0 -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include -I/usr/pkg/include/cairo -I/usr/X11R7/include/pixman-1 -I/usr/X11R7/include -I/usr/X11R7/include/freetype2 -I/usr/pkg/include/libpng16 -I/us
 r/pkg/include/harfbuzz -I/usr/pkg/include/glib/gio-unix-2.0/ -D_REENTRANT -I/usr/pkg/include/gdk-pixbuf-2.0 -D_REENTRANT -I/usr/pkg/include/atk-1.0 -D_REENTRANT -pthread -pthread  -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -I../.. -I/usr/pkg/include  -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2  -I/usr/pkg/include  -O2 -D_FORTIFY_SOURCE=2 -I/usr/pkg/include -I/usr/include -I/usr/X11R7/include -I/usr/X11R7/include/libdrm -I/usr/X11R7/include/freetype2 -Wall -MT hdr.o -MD -MP -MF ".deps/hdr.Tpo" -c -o hdr.o hdr.c; \
then mv -f ".deps/hdr.Tpo" ".deps/hdr.Po"; else rm -f ".deps/hdr.Tpo"; exit 1; fi
In file included from hdr.c:39:0:
fromrad.h:106:21: error: macro "fgets" requires 3 arguments, but only 1 given
 extern char  *fgets(), *resolu2str();
                     ^
fromrad.h:106:15: error: 'fgets' redeclared as different kind of symbol
 extern char  *fgets(), *resolu2str();
               ^
In file included from hdr.c:27:0:
/usr/include/stdio.h:229:7: note: previous declaration of 'fgets' was here
 char *fgets(char * __restrict, int, FILE * __restrict);
       ^
In file included from hdr.c:39:0:
fromrad.h:30:24: warning: 'g_bval' defined but not used [-Wunused-variable]
 static unsigned char (*g_bval)[256] = NULL;
                        ^
Makefile:371: recipe for target 'hdr.o' failed
[...]


This worked fine with both -8 and -current using GCC as of
pkgsrc-2017Q2.

Bulk builds using pkgsrc-HEAD and netbsd-8.99.1 and 8.99.2 w/GCC:

  http://mail-index.netbsd.org/pkgsrc-bulk/2017/09/07/msg014797.html
  http://mail-index.netbsd.org/pkgsrc-bulk/2017/09/21/msg014869.html

show the same failure.

Meanwhile, bulk buils using pkgsrc-HEAD on 8.99.2 and clang:

  http://mail-index.netbsd.org/pkgsrc-bulk/2017/09/09/msg014804.html
  http://mail-index.netbsd.org/pkgsrc-bulk/2017/09/10/msg014818.html
  http://mail-index.netbsd.org/pkgsrc-bulk/2017/09/15/msg014839.html
  http://mail-index.netbsd.org/pkgsrc-bulk/2017/09/19/msg014858.html
  http://mail-index.netbsd.org/pkgsrc-bulk/2017/09/21/msg014867.html

do not exhibit the failure.
>How-To-Repeat:
Attempt to build "graphics/cinepaint" from pkgsrc-HEAD with GCC on
netbsd-8 or -current.
>Fix:
The following patch solves the problem for netbsd-8:

--- plug-ins/hdr/fromrad.h.orig 2004-11-19 00:52:27.000000000 -0600
+++ plug-ins/hdr/fromrad.h      2017-09-21 23:43:27.719876410 -0500
@@ -104,7 +103,7 @@ extern char  resolu_buf[RESOLU_BUFLEN];
 #define  fprtresolu(sl,ns,fp)  fprintf(fp,PIXSTDFMT,ns,sl)
 #define  fscnresolu(sl,ns,fp)  (fscanf(fp,PIXSTDFMT,ns,sl)==2)
 
-extern char  *fgets(), *resolu2str();
+extern char *resolu2str();
 
 /* End of resolu.h defs */
 

It is not clear yet if this will negatively impact netbsd-7 or netbsd-6.