pkg/52558: pkgsrc- net/rtorrent fails to build with compile errors

[Simon Burge <simonb%NetBSD.org@localhost>]

>Number:         52558
>Category:       pkg
>Synopsis:       net/rtorrent fails to build with compile errors
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 19 10:45:00 +0000 2017
>Originator:     Simon Burge
>Release:        NetBSD 8.0_BETA (sources from 3 Sep 2017) and pkgsrc-2017Q2
>Organization:
Not really
>Environment:
System: NetBSD athlon.thistledown.com.au 8.0_BETA NetBSD 8.0_BETA (THOREAU) #2: Tue Sep 5 12:00:45 EST 2017 simonb%thoreau.thistledown.com.au@localhost:/NetBSD/src8/sys/arch/amd64/compile/THOREAU amd64
Architecture: x86_64
Machine: amd64
>Description:
	Trying to build net/rtorrent, the build fails with some type
	conversion errors.

	libtool: compile:  c++ -DHAVE_CONFIG_H -I. -I../.. -I./.. -I/home/simonb/netbsd/obj/pkg/net/libtorrent/work.athlon/.buildlink/include -pthread -O2 -fpermissive -fno-strength-reduce -fno-thread-jumps -fno-inline -fforce-addr -DNDEBUG -fvisibility=hidden -MT poll_kqueue.lo -MD -MP -MF .deps/poll_kqueue.Tpo -c poll_kqueue.cc  -fPIC -DPIC -o .libs/poll_kqueue.o
	In file included from /usr/include/errno.h:42:0,
			 from /usr/include/g++/cerrno:41,
			 from poll_kqueue.cc:39:
	poll_kqueue.cc: In member function 'void torrent::PollKQueue::modify(torrent::Event*, short unsigned int, short int)':
	poll_kqueue.cc:114:3: error: invalid static_cast from type 'torrent::Event*' to type '__intptr_t {aka long int}'
	   EV_SET(itr, event->file_descriptor(), mask, op, 0, 0, event);
	   ^
	poll_kqueue.cc: In member function 'virtual void torrent::PollKQueue::close(torrent::Event*)':
	poll_kqueue.cc:312:23: warning: ISO C++ forbids comparison between pointer and integer [-fpermissive]
	     if (itr->udata == event)
			       ^
	poll_kqueue.cc:313:18: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
	       itr->udata = NULL;
			  ^
	poll_kqueue.cc: In member function 'virtual void torrent::PollKQueue::closed(torrent::Event*)':
	poll_kqueue.cc:338:23: warning: ISO C++ forbids comparison between pointer and integer [-fpermissive]
	     if (itr->udata == event)
			       ^
	poll_kqueue.cc:339:18: warning: converting to non-pointer type 'long int' from NULL [-Wconversion-null]
	       itr->udata = NULL;
			  ^
	In file included from poll_kqueue.cc:50:0:
	../../rak/functional.h: In instantiation of 'bool rak::equal_t<Type, Ftor>::operator()(Arg&) [with Arg = kevent; Type = torrent::Event*; Ftor = rak::mem_ref_t<kevent, long int>]':
	/usr/include/g++/bits/predefined_ops.h:234:30:   required from 'bool __gnu_cxx::__ops::_Iter_pred<_Predicate>::operator()(_Iterator) [with _Iterator = kevent*; _Predicate = rak::equal_t<torrent::Event*, rak::mem_ref_t<kevent, long int> >]'
	/usr/include/g++/bits/stl_algo.h:866:20:   required from '_ForwardIterator std::__remove_if(_ForwardIterator, _ForwardIterator, _Predicate) [with _ForwardIterator = kevent*; _Predicate = __gnu_cxx::__ops::_Iter_pred<rak::equal_t<torrent::Event*, rak::mem_ref_t<kevent, long int> > >]'
	/usr/include/g++/bits/stl_algo.h:936:30:   required from '_FIter std::remove_if(_FIter, _FIter, _Predicate) [with _FIter = kevent*; _Predicate = rak::equal_t<torrent::Event*, rak::mem_ref_t<kevent, long int> >]'
	poll_kqueue.cc:316:83:   required from here
	../../rak/functional.h:97:16: warning: ISO C++ forbids comparison between pointer and integer [-fpermissive]
	     return m_t == m_f(a);
			^
	Makefile:584: recipe for target 'poll_kqueue.lo' failed

>How-To-Repeat:
	cd ..../pkgsrc/net/rtorrent && make
>Fix:
	None given.