pkg/52534: security/pinepgp build error

[paul%whooppee.com@localhost]

>Number:         52534
>Category:       pkg
>Synopsis:       security/pinepgp build error on NetBSD
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Sep 09 05:30:00 +0000 2017
>Originator:     Paul Goyette
>Release:        NetBSD 8.99.2
>Organization:
+------------------+--------------------------+----------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:          |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+------------------+--------------------------+----------------------------+
>Environment:
	
	
System: NetBSD speedy.whooppee.com 8.99.2 NetBSD 8.99.2 (SPEEDY 2017-08-30 21:55:55 UTC) #0: Thu Aug 31 03:05:47 UTC 2017 paul%speedy.whooppee.com@localhost:/build/netbsd-local/obj/amd64/sys/arch/amd64/compile/SPEEDY amd64
Architecture: x86_64
Machine: amd64
>Description:
	With current gcc compiler on NetBSD, the build for this package
	fails as follows:

	# /bin/cat pinegpgp.in | /usr/bin/sed -e 's%\@SED\@%/usr/bin/sed%; s%\@CAT\@%/bin/cat%; s%\@RM\@%/bin/rm%; s%\@MKTEMP\@%/usr/bin/mktemp%; s%\@BASH\@%/usr/pkg/bin/bash%; s%\@bindir\@%/usr/pkg/bin%; s%\@tmpdir\@%~/.pinepgp%' > pinegpgp
	# chmod 755 pinegpgp
	# gcc -E -DGPG -DUSE_MKTEMP -DUSE_NSE_FIX pinegpg.c | /usr/bin/grep -v "^# .* .*"> pinegpg
	# pinegpg.c:1:2: error: invalid preprocessing directive #!
	 #!/usr/pkg/bin/bash 
	  ^

	It then proceeds to install a shell script which has no #! line at
	the beginning.  When the script gets executed, it will use the user's
	current/default shell.  If the user happens to use csh (or some
	variant thereof), the variable assignment of 

		tmpdir=~/.pinegpg/

	fails, and subsequently the script will try to create its temp
	file in the system root file system.  Most users won't have the
	required permissions for this to success, so the script fails.
>How-To-Repeat:
	Build and install security/pinepgp on a _current_ NetBSD host.
	
>Fix:
	Fix it so the generated script file has a proper #! line at the top!

	As a work-around, you can modify the script to avoid using
	local variabkle assignments, especially to tmpdir
	

>Unformatted: