pkg/52513: www/curl doesn't build due to vestigial parts of a workaround in its make file

[dhgutteridge%sympatico.ca@localhost]

>Number:         52513
>Category:       pkg
>Synopsis:       www/curl doesn't build due to vestigial parts of a workaround in its make file
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Aug 29 02:30:00 +0000 2017
>Originator:     David H. Gutteridge
>Release:        HEAD
>Organization:
>Environment:
n/a
>Description:
After www/curl was bumped to 7.55.1, some vestigial code for a
workaround for 7.55.0 was left in the make file. This causes build
failures when the host has a different version of Automake installed
than expected.

===> Configuring for curl-7.55.1nb1
cd /home/disciple/pkgsrc/www/curl/work/curl-7.55.1 && automake
configure.ac:127: error: version mismatch.  This is Automake 1.15,
configure.ac:127: but the definition used by this AM_INIT_AUTOMAKE
configure.ac:127: comes from Automake 1.15.1.  You should recreate
configure.ac:127: aclocal.m4 with aclocal and run automake again.
*** Error code 63

Stop.
make[1]: stopped in /home/disciple/pkgsrc/www/curl
*** Error code 1

>How-To-Repeat:
As above.
>Fix:
--- Makefile.orig	2017-08-28 20:09:27.361795702 -0400
+++ Makefile	2017-08-28 20:49:40.803209066 -0400
@@ -25,11 +25,6 @@
 
 INSTALLATION_DIRS=	share/doc/curl
 
-# only needed for 7.55.0 due to a bug, see patches/patch-Makefile.am
-USE_TOOLS+=		automake
-pre-configure:
-	cd ${WRKSRC} && automake
-
 .include "../../mk/bsd.prefs.mk"
 
 .if !empty(PKGSRC_RUN_TEST:M[Yy][Ee][Ss])