pkg/52488: pkgsrc databases/postgresql-pgpool2 3.6.5 update

[dogan%tesmer.org.tr@localhost]

>Number:         52488
>Category:       pkg
>Synopsis:       pkgsrc databases/postgresql-pgpool2 3.6.5 update
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 16 17:40:00 +0000 2017
>Originator:     Mustafa Dogan
>Release:        NetBSD 7.1_STABLE
>Organization:
TESMER
>Environment:
NetBSD research.net.md 7.1_STABLE NetBSD 7.1_STABLE (GENERIC) #0: Sat Aug 12 14:34:13 +03 2017  root@localhost:/root/OBJ/sys/arch/amd64/compile/GENERIC amd64
>Description:
After last update of databases/pgpool2 package, more than a year ago, lots of bugs fixed and many changes made to pgpool-II.

Notable changes:
Release 3.6.1
Release Date: 2016-12-26
Tightening up the watchdog security. (Muhammad Usama)
Add pgpool_adm extension in Pgpool-II RPM. (Bo Peng)
Fix occasional segfault when query cache is enabled. (bug 263) (Tatsuo Ishii)
Fix packet kind does not match error in extended protocol. (bug 231)
(Tatsuo Ishii)
Fix a race condition in a signal handler. (bug 265) (Tatsuo Ishii)
Fix wrong minimum configuration value for client_idle_limit_in_recovery.
(bug 264) (Tatsuo Ishii)
Allow to execute "make xslthtml" under doc.ja. (Tatsuo Ishii)

Release 3.6.2
Release Date: 2017-03-17
Add "Wants=network.target" to pgpool.service file. (bug 294) (Bo Peng)
Fix pcp_promote_node bug that fails promoting node 0. (Yugo Nagata)
Fix document error. (Tatsuo Ishii, Bo Peng)
Pgpool-IIshould not perform ping test after bringing down the VIP.
(Muhammad Usama)
Fix to release shared memory segments when Pgpool-IIexits. (bug 272)
(Tatsuo Ishii)
Fix for [pgpool-general: 5315] pg_terminate_backend (Muhammad Usama)
Adding the missing ExecStop and ExecReload commands to the systemd service
configuration file. (Muhammad Usama)
Fix for 281: "segmentation fault" when execute pcp_attach_node. (bug 281)
(Muhammad Usama)
Fix load balancing bug in streaming replication mode. (Tatsuo Ishii)
Fix yet another kind mismatch error in streaming replication mode. (Tatsuo
Ishii)
Fix do_query()hangs after close message. (Tatsuo Ishii)
Fixing stack smashing detected. (bug 280) (Muhammad Usama)
Fixing the issue with the watchdog process restart. (Muhammad Usama)
Fix query cache bug reported in pgpool-general-jp:1441. (Tatsuo Ishii)
Remove elog/ereport calls from signal handlers. (Tatsuo Ishii)
Fix bug failed to create INET domain socket in FreeBSD if listen_addresses
= '*'. (bug 202) (Bo Peng)
Fix for 0000249: watchdog sometimes fails de-escalation. (bug 249)
(Muhammad Usama)
Fix connection_life_time broken by authentication_timeout. (Yugo Nagata)
Fix authentication timeout that can occur right after client connecttions.
(Yugo Nagata)

Release 3.6.3
Release Date: 2017-04-28
Fix "show pool_cache" segfault when memcached is used. (Bug 301) (Tatsuo
Ishii)
Fix for some more code warnings. (Muhammad Usama)
Fixing some annoying compiler warnings. (Muhammad Usama)
Removing the function defined but not used warnings from
pool_config_vatiable.c (Muhammad Usama)
Removing the references of obsolete debug_level configuration parameter.
(Muhammad Usama)
Fixing a mistake in the watchdog code. (Muhammad Usama)
Fix for 0000299: Errors on the reloading of configuration. (Bug 299)
(Muhammad Usama)
Add pgpool_adm English and Japanese docs. (Tatsuo Ishii)
Fix document indentation. (Tatsuo Ishii)
Fix for 0000289: Inconsistent backend state. (Bug 289) (Muhammad Usama)
Enhancing the handling of split-brain scenario by the watchdog. (Muhammad
Usama)
Enhancing the watchdog internal command mechanism to handle multiple
concurrent commands. (Muhammad Usama)
Fix compiler warnings. (Tatsuo Ishii)
Comment out unsupported Java method in new JDBC drivers to prevent
regression failure. (Tatsuo Ishii)
Downgrade parse before bind log message to debug1. (Tatsuo Ishii)
Fix coverity warnings. (Tatsuo Ishii, Muhammad Usama)
Fix for [pgpool-general: 5396] pam ldap failure. (Muhammad Usama)
Mention that SQL type commands cannot be used in extended query mode.
(Tatsuo Ishii)
Consider SHOW command as kind of a read query. (Tatsuo Ishii)
Fix memory leak problem caused by commit adcb636. (Tatsuo Ishii)
Mega patch to fix "kind mismatch" (or derived) errors in streaming
replication mode. (Bug 271) (Tatsuo Ishii)
Fix for 0000296: PGPool v3.6.2 terminated by systemd because the service
Type has been set to 'forking'. (Bug 296) (Muhammad Usama)

Release 3.6.4
Release Date: 2017-05-11
Fixing a few corner cases in the failover request handling of the
watchdog. (Muhammad Usama)
Tightening up the watchdog cluster membership criteria. (Muhammad Usama)
Enhance document for load balancing. (Tatsuo Ishii)
Add node 0 failover test. (Tatsuo Ishii)
Fix Pgpool-II child process segfault reported in [pgpool-hackers: 2312].
(Tatsuo Ishii)

Release 3.6.5
Release Date: 2017-07-11
Fix for [pgpool-hackers: 2400] Garbage output (Muhammad Usama)
Importing the latest changes in the MemoryManager API from PostgreSQL
code. (Muhammad Usama)
Fixing 0000306: Pgpool steals back MASTER status. (bug 306) (Muhammad Usama)
Fixing [pgpool-hackers: 2390]Problems with the relative paths in daemon
mode (Muhammad Usama)
Adjust function name change in PostgreSQL 10 dev head. (Tatsuo Ishii)
Fix a posible hang with streaming replication and extended protocol. (Yugo
Nagata)
Fix Pgpool-II hang when used by erlang applications. (Tatsuo Ishii)
Fix bug with sending bind message to wrong target node. (bug 314) (Tatsuo
Ishii)
Fix query cache hang when used by node.js. (Tatsuo Ishii)
Deal with PostgreSQL 10 in streaming replication delay checking. (Tatsuo
Ishii)
Fix query cache memory leak. (Tatsuo Ishii)
Fix extended query hang in certain case. (Tatsuo Ishii)
Fix for [pgpool-hackers: 2354] segfault with pg_md5. (Muhammad Usama)
Fix descriptions of white/black_memcache_table_list. (Tatsuo Ishii)
Fix corner case bug in Pgpool-II starting up. (Tatsuo Ishii)
>How-To-Repeat:

>Fix:
Patches:
--- configure.orig        2017-07-10 11:56:18.000000000 +0300
+++ configure        2017-07-26 12:34:56.000000000 +0300
@@ -3999,7 +3999,7 @@ fi


 # Define the identity of the package.
- PACKAGE='pgpool-II'
+ PACKAGE='pgpool2'
  VERSION='3.6.5'

======================================================================
--- src/include/pool.h.orig        2017-07-10 11:56:18.000000000 +0300
+++ src/include/pool.h        2017-07-26 12:34:56.000000000 +0300
@@ -82,7 +82,7 @@
 #define DEFAULT_WD_IPC_SOCKET_DIR "/tmp"

 /* pid file name */
-#define DEFAULT_PID_FILE_NAME "/var/run/pgpool/pgpool.pid"
+#define DEFAULT_PID_FILE_NAME "@PGPOOL_PIDDIR@/pgpool.pid"

 /* status file name */
 #define STATUS_FILE_NAME "pgpool_status"

======================================================================
--- src/sample/pgpool.conf.sample.orig        2017-07-10 11:56:18.000000000 +0300
+++ src/sample/pgpool.conf.sample        2017-07-26 12:34:56.000000000 +0300
@@ -210,13 +210,13 @@ syslog_ident = 'pgpool'
 # FILE LOCATIONS
 #------------------------------------------------------------------------------

-pid_file_name = '/var/run/pgpool/pgpool.pid'
+pid_file_name = '@PGPOOL_PIDDIR@/pgpool.pid'
                                    # PID file name
                                    # Can be specified as relative to the"
                                    # location of pgpool.conf file or
                                    # as an absolute path
                                    # (change requires restart)
-logdir = '/var/log/pgpool'
+logdir = '@PGPOOL_LOGDIR@'
                                    # Directory of pgPool status file
                                    # (change requires restart)

@@ -709,7 +709,7 @@ memqcache_cache_block_size = 1048576
                                                                    # Cache block size in bytes. Mandatory if memqcache_method =
'shmem'.
                                                                    # Defaults to 1MB.
                                    # (change requires restart)
-memqcache_oiddir = '/var/log/pgpool/oiddir'
+memqcache_oiddir = '@PGPOOL_LOGDIR@/oiddir'
                                                                       # Temporary work directory to record table oids
                                    # (change requires restart)
 white_memqcache_table_list = ''

======================================================================
--- src/watchdog/wd_escalation.c.orig        2017-07-10 11:39:14.000000000 +0300
+++ src/watchdog/wd_escalation.c        2017-07-26 12:34:56.000000000 +0300
@@ -27,9 +27,7 @@
 #include <unistd.h>
 #include <errno.h>

-#ifdef __FreeBSD__
 #include <sys/wait.h>
-#endif

 #include "pool.h"
 #include "utils/elog.h"