Re: pkg/52457: audio/rplay does not compile on NetBSD 7.1

[Jörn Clausen <joernc%googlemail.com@localhost>]

The following reply was made to PR pkg/52457; it has been noted by GNATS.

From: =?UTF-8?Q?J=C3=B6rn_Clausen?= <joernc%googlemail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/52457: audio/rplay does not compile on NetBSD 7.1
Date: Sun, 6 Aug 2017 18:32:38 +0200

 Unless someone steps forward and is actually using vtwm from pkgsrc
 with sound, this should fix the problem:
 
 --- Makefile    2017/08/06 16:21:35     1.1
 +++ Makefile    2017/08/06 16:21:43
 @@ -15,7 +15,6 @@
  USE_IMAKE=3D     YES
  USE_TOOLS+=3D    flex yacc
 
 -.include "../../audio/rplay/buildlink3.mk"
  .include "../../x11/libXext/buildlink3.mk"
  .include "../../x11/libXmu/buildlink3.mk"
  .include "../../x11/libXpm/buildlink3.mk"
 
 and patch-aa
 
 $NetBSD: patch-aa,v 1.2 2006/01/02 22:13:26 joerg Exp $
 
 --- Imakefile.orig    2005-05-09 12:46:24.000000000 +0000
 +++ Imakefile
 @@ -26,10 +26,10 @@ XCOMM and comment these
  XCOMM (the library must conform to the POSIX 1003.2 specification)
 
  XCOMM To omit sound support, uncomment this
 -XCOMM NO_SOUND_SUPPORT =3D -DNO_SOUND_SUPPORT
 +NO_SOUND_SUPPORT =3D -DNO_SOUND_SUPPORT
  XCOMM and comment these
 -SOUNDLIB =3D -L/usr/local/lib -lrplay
 -SOUNDINC =3D -I/usr/local/include
 +XCOMM SOUNDLIB =3D -L${PREFIX}/lib ${COMPILER_RPATH_FLAG}${PREFIX}/lib -lr=
 play
 +XCOMM SOUNDINC =3D -I/usr/local/include
  XCOMM (sound is supported only by way of the rplay library)
 
  XCOMM To omit Internationalization support, uncomment this
 @@ -57,7 +57,7 @@ XCOMM Installation path for the binary
         VTWMBINDIR =3D $(BINDIR)
 
  XCOMM Installation path for the system resource file
 -       VTWMLIBDIR =3D $(LIBDIR)/twm
 +       VTWMLIBDIR =3D $(LIBDIR)/vtwm
 
  XCOMM Installation path for the man page
         VTWMMANDIR =3D $(MANDIR)
 
 
 
 On Wed, Aug 2, 2017 at 11:05 PM,  <joernc%gmail.com@localhost> wrote:
 >>Number:         52457
 >>Category:       pkg
 >>Synopsis:       audio/rplay does not compile on NetBSD 7.1
 >>Confidential:   no
 >>Severity:       serious
 >>Priority:       medium
 >>Responsible:    pkg-manager
 >>State:          open
 >>Class:          sw-bug
 >>Submitter-Id:   net
 >>Arrival-Date:   Wed Aug 02 21:05:00 +0000 2017
 >>Originator:     Joern Clausen
 >>Release:        7.1
 >>Organization:
 >>Environment:
 >>Description:
 > Compiling audio/rplay fails on NetBSD 7.1/amd64 with
 >
 > gcc -c -I/usr/pkg/include -I/usr/include -I. -I../include -I. -I./../incl=
 ude  -I./../lib -I./../adpcm   -DHAVE_CONFIG_H  -DRPLAY_CONF=3D\"/usr/pkg/e=
 tc/rplay.conf\"  -DRPLAY_HOSTS=3D\"/usr/pkg/etc/rplay.hosts\"  -DRPLAY_SERV=
 ERS=3D\"/usr/pkg/etc/rplay.servers\"  -DRPLAY_HELPERS=3D\"/usr/pkg/etc/rpla=
 y.helpers\"  -DRPLAY_CACHE=3D\"/tmp/.rplay-cache\"  -DRPLAY_LOG=3D\"/tmp/rp=
 lay.log\"  -DRPLAYDRC=3D\"\~/.rplaydrc\" -O2 -D_FORTIFY_SOURCE=3D2 -I/usr/p=
 kg/include -I/usr/include cache.c
 > cache.c: In function 'cache_next':
 > cache.c:131:88: error: macro "__ssp_bos" passed 2 arguments, but takes ju=
 st 1
 >      SNPRINTF(SIZE(cache_path, sizeof(cache_path)), "%s/%s", cache_direct=
 ory, dp->d_name);
 >                                                                          =
                ^
 > In file included from /usr/include/stdio.h:593:0,
 >                  from cache.c:40:
 > ../include/config.h:291:18: error: '__ssp_bos' undeclared (first use in t=
 his function)
 >  #define SNPRINTF snprintf
 >                   ^
 > cache.c:131:5: note: in expansion of macro 'SNPRINTF'
 >      SNPRINTF(SIZE(cache_path, sizeof(cache_path)), "%s/%s", cache_direct=
 ory, dp->d_name);
 >      ^
 > ../include/config.h:291:18: note: each undeclared identifier is reported =
 only once for each function it appears in
 >  #define SNPRINTF snprintf
 >                   ^
 > cache.c:131:5: note: in expansion of macro 'SNPRINTF'
 >
 >
 > and some more failures.
 >>How-To-Repeat:
 >
 >>Fix:
 > Instead of fixing rplay, removing it as a dependency for wm/vtwm is also =
 okay for me :)
 >
 
 
 
 --=20
 Joern Clausen
 http://www.oe-files.de/photography/