pkg/52309: firefox 54.0 build fails on NetBSD 7.1

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

	Note: There was a bad value `firefox 54.0 build fails on NetBSD/i386 7.1' for the field `Severity'.
	It was set to the default value of `serious'.

>Number:         52309
>Category:       pkg
>Synopsis:       pkg
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jun 18 13:25:00 +0000 2017
>Originator:     Izumi Tsutsui
>Release:        NetBSD 7.1 + pkgsrc HEAD
>Organization:
>Environment:
System: NetBSD 7.1
Architecture: i386
Machine: i386
>Description:
Building recently updated firefox 54.0 fails on NetBSD/i386 7.1:

> [...]/firefox-54.0/ipc/chromium/src/base/lock_impl_posix.cc:35:46: error: 'PTHREAD_PRIO_INHERIT' was not declared in this scope

It looks NetBSD -current (and netbsd-8) has PTHREAD_PRIO_INHERIT
in <pthread.h> but 7.1 doesn't.
http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libpthread/pthread.h#rev1.37

>How-To-Repeat:
Build pkgsrc HEAD firefox 54.0 on NetBSD/i386 7.1.

>Fix:
The lock_impl_posix.cc seems to have ifdef to disable
PRIORITY_INHERITANCE_LOCKS.

Disabling it (via patch-ipc_chromium_src_base_lock__impl__posix.cc)
on NetBSD without PTHREAD_PRIO_INHERIT works around.

---
$NetBSD$

- Fix build on NetBSD 7.1 (which doesn't have PTHREAD_PRIO_INHERIT)

--- ipc/chromium/src/base/lock_impl_posix.cc.orig	2017-06-05 20:45:20.000000000 +0000
+++ ipc/chromium/src/base/lock_impl_posix.cc
@@ -20,7 +20,7 @@ namespace internal {
 // Lock::PriorityInheritanceAvailable still must be checked as the code may
 // compile but the underlying platform still may not correctly support priority
 // inheritance locks.
-#if defined(OS_NACL) || defined(OS_ANDROID)
+#if defined(OS_NACL) || defined(OS_ANDROID) || (defined(__NetBSD__) && !defined(PTHREAD_PRIO_INHERIT))
 #define PRIORITY_INHERITANCE_LOCKS_POSSIBLE() 0
 #else
 #define PRIORITY_INHERITANCE_LOCKS_POSSIBLE() 1

---