pkg/52044: please bump net/openvpn port to new version

[gert%greenie.muc.de@localhost]

>Number:         52044
>Category:       pkg
>Synopsis:       please bump net/openvpn port to new version
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 07 07:45:00 +0000 2017
>Originator:     Gert Doering
>Release:        HEAD, 2017/03/07
>Organization:
>Environment:
NetBSD nbsd70.ov.greenie.net 7.0.1 NetBSD 7.0.1 (GENERIC.201605221355Z) i386

>Description:
net/openvpn is at 2.3.11 right now.

Current upstream version is 2.3.14 in the "old stable" branch, or 2.4.0 in the "new stable" branch.  

FreeBSD moved to 2.4.0 (plus added an net/openvpn23), but which version you choose depends a bit on how conservative NetBSD's pkgsrc regime is.  2.4.0 has lots of important enhancements, like AEAD crypto.

In any case, when working on that port, please remove patches/patch-ac - this adds code that already exists in upstream sources (since years ago), just a few lines earlier in tun.c - so it's a complicated way to do a no-op.

When going to 2.4.0, patches/patch-ad, patch-ae, patch-af and patch-src_openvpn_socket.[ch] can be dropped as well as the necessary adjustments have been made to upstream source - so it won't apply, and is not needed anymore.  2.4.0 compiles and passes all tests on NetBSD "out of the box", no patches needed :-)


>How-To-Repeat:
"checkout pkgsrc"
>Fix:
bump OPENVPN_DISTNAME to openvpn-2.3.14 or openvpn-2.4.0

(since this is coming from "Makefile.common", used by openvpn-nagios and openvpn-acct-wtmx, double-checking sounds like a good idea when going to 2.4.0 - 2.3.14 should be a drop-in replacement)