Re: pkg/51899: Fix for building qemu on Darwin

[Yuji Yamano <yyamano%kt.rim.or.jp@localhost>]

The following reply was made to PR pkg/51899; it has been noted by GNATS.

From: Yuji Yamano <yyamano%kt.rim.or.jp@localhost>
To: js-pkgsrc%heap.zone@localhost, gnats-bugs%NetBSD.org@localhost
Cc: dholland-pbugs%netbsd.org@localhost, coypu%SDF.ORG@localhost
Subject: Re: pkg/51899: Fix for building qemu on Darwin
Date: Tue, 31 Jan 2017 14:08:32 +0900 (JST)

 Jonathan,
 
 Could you try the attached patch?
 
 I think I finally found the root cause. 
 _XOPEN_SOURCE_EXTENDED is exported via CFLAGS by the pkgsrc framework,
 but qemu doesn't support CFLAGS. We need to use --extra-cflags instead.
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/emulators/qemu/Makefile,v
 retrieving revision 1.163
 diff -u -r1.163 Makefile
 --- Makefile	17 Jan 2017 09:10:11 -0000	1.163
 +++ Makefile	31 Jan 2017 05:01:32 -0000
 @@ -43,6 +43,7 @@
  CONFIGURE_ARGS+=	--enable-curses
  #HF#CONFIGURE_ARGS+=	--disable-fdt			# HF: build on OS X
  CONFIGURE_ARGS+=	--disable-opengl
 +CONFIGURE_ARGS+=	--extra-cflags="${CFLAGS}"	
  CONFIGURE_ENV+=		mansuffix=/${PKGMANDIR}
  
  .if defined(PKGSRC_USE_SSP)