Re: pkg/51502: readline 7.0 failed to build on Solaris 10

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/51502; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/51502: readline 7.0 failed to build on Solaris 10
Date: Sun, 20 Nov 2016 00:58:37 +0000

 On Sat, Sep 24, 2016 at 11:30:01AM +0000, Joerg Sonnenberger wrote:
  >  > test -d examples || mkdir examples
  >  > (cd examples && /usr/pkg/bin/bmake   all )
  >  > rm -f fileman.o
  >  > libtool  --mode=link gcc-4.9 -DHAVE_CONFIG_H -DREADLINE_LIBRARY -DRL_LIBRARY_VERSION='"7.0"' -I. -I.. -I.. -I/usr/include -O2 -I/usr/include -c fileman.c
  >  > libtool: link: you must specify an output file
  >  > libtool: link: Try `libtool --help --mode=link' for more information.
  >  > *** Error code 1
  >  
  >  What exactly is your mk.conf?
 
 This is the problem:
 
    CC = $(LIBTOOL) --mode=link @CC@
       :
    .c.o:
            ${RM} $@
            $(CC) $(CCFLAGS) -c $<
 
 Of course that doesn't work.
 
 The other thing is: in the original report the build didn't actually
 fail. It says "*** Error code 1 (ignored)", because it seems for some
 reason that the build system tries to build the examples but blithely
 continues if they fail. This is a bug - it should either build the
 examples or skip them but not go halfway.
 
 So you can (AFAICT) actually continue to install after this; it just
 looks like it died.
 
 If you set MAKE_JOBS (as Joerg and most of us with big build machines
 do) the apparent problem disappears, because due to a third makefile
 bug it tries to build the examples before it's built the readline
 library, so the examples build dies right up front and one doesn't
 notice.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost