pkgsrc-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: pkg/51534: qemu-2.7.0 fails to build: bad register name



On Fri, Oct 07, 2016 at 07:20:00PM +0000, Kamil Rytarowski wrote:
>  2. changing from append to prepend is no-operation for qemu

That's rather obviously wrong as the patch wouldn't work if there was no
difference.

>  3. changing from append to prepend might create new hard to debug issues
>  (like ABI mismatch) in fragile makefiles as the last -mABI wins and it
>  won't be corrected

This is exactly the intended goal. If a package explicitly specifies an
ABI, it should win. That's the whole point of the proposal to move to
prepend.

>  This is why I prefer to let some software to have specified/injected
>  ${_COMPILER_ABI_FLAG.${ABI}} where needed. And my '-1" patch must be
>  extended to pass ${_COMPILER_ABI_FLAG.${ABI}} accordingly. Changing
>  things to prepend just hides the issue. For now just qemu is affected
>  and I wouldn't reinvent new way to inject -mABI for every package for
>  singular exceptions.

qemu needs special help because it wants to build a BIOS image, which
has special ABI requirements. The *normal* qemu binary is still supposed
to have the *normal* pkgsrc ABI.

Joerg


Home | Main Index | Thread Index | Old Index