Re: pkg/51424: pkgtools/libnbcompat string.h header does not properly guard strdup definition

[Joerg Sonnenberger <joerg%bec.de@localhost>]

The following reply was made to PR pkg/51424; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: joerg%NetBSD.org@localhost, gnats-admin%netbsd.org@localhost, pkgsrc-bugs%netbsd.org@localhost,
	will%worrbase.com@localhost
Subject: Re: pkg/51424: pkgtools/libnbcompat string.h header does not
 properly guard strdup definition
Date: Sat, 20 Aug 2016 13:29:21 +0200

 On Sat, Aug 20, 2016 at 12:10:00AM +0000, William Orr wrote:
 >  It's not that the configure test fails, it's that the configure test
 >  doesn't define HAVE_DECL_STRDUP - it defines HAVE_STRDUP. Normally, this
 >  would just shadow the declaration of strdup, but because strdup is a
 >  macro on this system, the preprocessor mangles the definition in
 >  nbcompat/string.h. When the header compilation check runs on
 >  nbcompat/string.h, this results in a compilation failure.
 
 This is not true. When the detection works correctly, it does define
 HAVE_DECL_STRDUP. This is *not* a test for a function, but for an actual
 usable prototype and function.
 
 Joerg