pkg/51424: pkgtools/libnbcompat string.h header does not properly guard strdup definition

[will%worrbase.com@localhost]

>Number:         51424
>Category:       pkg
>Synopsis:       pkgtools/libnbcompat string.h header does not properly guard strdup definition
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Aug 18 06:30:00 +0000 2016
>Originator:     William Orr
>Release:        current
>Organization:
>Environment:
Linux locke.worr.haus 4.6.5-200.fc23.x86_64 #1 SMP Thu Jul 28 01:10:25 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
>Description:
When trying to build stuff that relies on libnbcompat on Linux,
compilation fails in the case that strdup is defined as a macro. There
seems to be a mistake in the feature guard for the function prototype in
libnbcompat
>How-To-Repeat:
1. Install libnbcompat on a modern Fedora
2. Try and build pkgin
>Fix:
Index: pkgtools/libnbcompat/files/nbcompat/string.h
===================================================================
RCS file: /cvsroot/pkgsrc/pkgtools/libnbcompat/files/nbcompat/string.h,v
retrieving revision 1.3
diff -u -b -w -p -r1.3 string.h
--- pkgtools/libnbcompat/files/nbcompat/string.h	8 Jun 2015 00:44:46 -0000	1.3
+++ pkgtools/libnbcompat/files/nbcompat/string.h	18 Aug 2016 05:37:36 -0000
@@ -40,7 +40,7 @@
  * Declare functions and macros that may be missing in <string.h>.
  */
 
-#if !HAVE_DECL_STRDUP
+#if !HAVE_STRDUP
 char	*strdup(const char *);
 #endif