pkg/51421: net/net-snmp doesn't build on FreeBSD 10+

[denafcm%gmail.com@localhost]

>Number:         51421
>Category:       pkg
>Synopsis:       net/net-snmp doesn't build on FreeBSD 10+
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 17 17:05:00 +0000 2016
>Originator:     Dennis Lindroos
>Release:        pkgsrc-2016Q2
>Organization:
>Environment:
FreeBSD 10.2-PRERELEASE
>Description:
Package net/net-snmp-5.7.3 does not build on FreeBSD 10, configure fails with "configure: error: Perl support requires --enable-shared", and two other problems.

This should be added to patches/patch-af, freebsd1* should not match freebsd10 (does anybody use freebsd1 anyway ?:)

--- configure.orig      2014-12-08 22:23:37.000000000 +0200
+++ configure   2016-08-17 17:59:41.062784000 +0300
@@ -13023,7 +13023,7 @@
       hardcode_shlibpath_var=no
       ;;

-    freebsd1*)
+    freebsd1)
       ld_shlibs=no
       ;;

@@ -14017,7 +14017,7 @@
   shlibpath_var=LD_LIBRARY_PATH
   ;;

-freebsd1*)
+freebsd1)
   dynamic_linker=no
   ;;

In patches/patch-agent_mibgroup_hardware_fsys_fsys_getfsstats.c, the "ifdef __APPLE__" should also include __FreeBSD__ (or similar..)

In patches/patch-agent_mibgroup_hardware_cpu_cpu__sysctl.c should add a semi-colon to the line 46 "snmp_log(LOG_ERR, "sysctl machdep.cpu_brand failed (errno %d)\n", errno)".


>How-To-Repeat:
Build with the "perl" option (which is in PKG_SUGGESTED_OPTIONS anyway).
>Fix: