pkg/51382: xenkernel42 does not build on NetBSD-current

[gson%gson.org@localhost (Andreas Gustafsson)]

>Number:         51382
>Category:       pkg
>Synopsis:       xenkernel42 does not build on NetBSD-current
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 31 15:50:00 +0000 2016
>Originator:     Andreas Gustafsson
>Release:        NetBSD-current, source date 2016.07.08.09.15.38
>Organization:

>Environment:
System: NetBSD
Architecture: x86_64
Machine: amd64
>Description:

When I try to build the xenkernel42 package from the current pkgsrc on
a NetBSD-current/amd64 system (CVS source date 2016.07.08.09.15.38),
compilation fails as follows:

  gcc -O2 -I/usr/include -I/usr/pkg/include  -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -DNDEBUG -fno-builtin -fno-common -Wredundant-decls -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include  -I/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include/asm-x86/mach-generic -I/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include/asm-x86/mach-default  -msoft-float -fno-stack-protector -fno-exceptions -Wnested-externs -mno-red-zone -mno-sse -fpic -fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -nostdinc -g -D__XEN__ -include /usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include/xen/config.h -DHAS_ACPI -DHAS_GDBSX -DHAS_PASSTHROUGH -MMD -MF .xen.d  -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-sta
 tement -
 Wno-unused-but-set-variable -Wno-unused-local-typedefs   -DNDEBUG -fno-builtin -fno-common -Wredundant-decls -iwithprefix include -Werror -Wno-pointer-arith -pipe -I/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include  -I/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include/asm-x86/mach-generic -I/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include/asm-x86/mach-default  -msoft-float -fno-stack-protector -fno-exceptions -Wnested-externs -mno-red-zone -mno-sse -fpic -fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -nostdinc -g -D__XEN__ -include /usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include/xen/config.h -DHAS_ACPI -DHAS_GDBSX -DHAS_PASSTHROUGH -MMD -MF .built_in.o.d  -O2 -fomit-frame-pointer -m64 -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wdeclaration-after-statement -Wno-unused-but-set-variable -Wno-unused-local-typedefs   -DNDEBUG -fno-builtin -fno-common -Wredundant-decls -iwithprefix include -Werror -Wno-point
 er-arith
  -pipe -I/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include  -I/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include/asm-x86/mach-generic -I/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include/asm-x86/mach-default  -msoft-float -fno-stack-protector -fno-exceptions -Wnested-externs -mno-red-zone -mno-sse -fpic -fno-asynchronous-unwind-tables -DGCC_HAS_VISIBILITY_ATTRIBUTE -nostdinc -g -D__XEN__ -include /usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/include/xen/config.h -DHAS_ACPI -DHAS_GDBSX -DHAS_PASSTHROUGH -MMD -MF .symbols.o.d -c symbols.c -o symbols.o
  symbols.c: In function 'symbols_lookup':
  symbols.c:23:61: error: array subscript is above array bounds [-Werror=array-bounds]
   #define symbols_address(n) (SYMBOLS_ORIGIN + symbols_offsets[n])
							       ^
  symbols.c:122:47: note: in expansion of macro 'symbols_address'
       while (low && symbols_address(low - 1) == symbols_address(low))
						 ^
  symbols.c:23:61: error: array subscript is above array bounds [-Werror=array-bounds]
   #define symbols_address(n) (SYMBOLS_ORIGIN + symbols_offsets[n])
							       ^
  symbols.c:130:13: note: in expansion of macro 'symbols_address'
	   if (symbols_address(i) > symbols_address(low)) {
	       ^
  cc1: all warnings being treated as errors
  gmake[3]: *** [/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/Rules.mk:156: symbols.o] Error 1
  gmake[3]: Leaving directory '/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/common'
  gmake[2]: *** [/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/Rules.mk:144: /usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/common/built_in.o] Error 2
  gmake[2]: Leaving directory '/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/arch/x86'
  gmake[1]: *** [Makefile:98: /usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen/xen] Error 2
  gmake[1]: Leaving directory '/usr/pkgsrc/sysutils/xenkernel42/work/xen-4.2.5/xen'
  gmake: *** [Makefile:25: build] Error 2
  *** Error code 2

  Stop.
  make[1]: stopped in /usr/pkgsrc/sysutils/xenkernel42

I'm guessing it's the same issue as in

  https://lists.xenproject.org/archives/html/xen-devel/2015-03/msg01687.html

>How-To-Repeat:

>Fix: