pkg/51354: mail/postfix eai option does not work because of test in makedef

[pkgsrc%xn--rvztrtkrfrgp-bbb7j2b8f0b9d7a21oft.com@localhost]

>Number:         51354
>Category:       pkg
>Synopsis:       mail/postfix eai option does not work because of test in makedef
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 21 00:40:00 +0000 2016
>Originator:     Ben Gergely
>Release:        current
>Organization:
>Environment:
NetBSD amd64
>Description:
When building postfix with eai enabled a check in makedefs adds -DNO_EAI incorrectly to CCARGS:

-DHAS_EAI -I/usr/pkg/include -DNO_EAI

the eai option in options.mk is correct.
>How-To-Repeat:


cd /usr/pkgsrc/mail/postfix ; make clean ; make configure PKG_OPTIONS.postfix=eai ; grep "DHAS_EAI" ./work/postfix-3.0.2/Makefile
>Fix:
remove the test in makedefs as it's handled with the options framework

--- ./makedefs  2016-07-21 01:19:47.478264694 +0100
+++ /tmp/makedefs       2016-07-21 01:22:08.399316881 +0100
@@ -655,42 +655,6 @@
 esac
 
 #
-# Look for the ICU library and enable unicode email if available.
-#
-case "$CCARGS" in
- *-DNO_EAI*) ;;
-          *) trap 'rm -f makedefs.test makedefs.test.[co]' 1 2 3 15
-             cat >makedefs.test.c <<'EOF'
-#include <unicode/uidna.h>
-#include <stdlib.h>
-
-int main(int argc, char **argv)
-{
-    char    buf[1024];
-    UErrorCode error = U_ZERO_ERROR;
-    UIDNAInfo info = UIDNA_INFO_INITIALIZER;
-    UIDNA  *idna = uidna_openUTS46(UIDNA_DEFAULT, &error);
-
-    exit(uidna_labelToUnicodeUTF8(idna,
-                                 "xn--lgbbat1ad8j",    /* an arabic TLD */
-                                 15,
-                                 buf,
-                                 sizeof(buf),
-                                 &info,
-                                 &error) != 14);
-}
-EOF
-             ${CC-gcc} -o makedefs.test makedefs.test.c -I/usr/local/include \
-               -L/usr/local/lib -licuuc >/dev/null 2>&1
-             if ./makedefs.test 2>/dev/null ; then
-                 SYSLIBS="$SYSLIBS -L/usr/local/lib -licuuc"
-             else
-                 CCARGS="$CCARGS -DNO_EAI"
-             fi
-             rm -f makedefs.test makedefs.test.[co]
-esac
-
-#
 # OpenSSL has no configuration query utility, but we don't try to
 # guess. We assume includes in /usr/include/openssl and libraries in
 # /usr/lib, or in their /usr/local equivalents. If the OpenSSL files