Re: pkg/46570 (infelicities in pkglint)

[Roland Illig <roland.illig%gmx.de@localhost>]

The following reply was made to PR pkg/46570; it has been noted by GNATS.

From: Roland Illig <roland.illig%gmx.de@localhost>
To: gnats-bugs%NetBSD.org@localhost, dholland%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/46570 (infelicities in pkglint)
Date: Sun, 12 Jun 2016 08:22:51 +0200

 Am 12.06.2016 um 02:55 schrieb David Holland:
 >   	// See pkgtools/createbuildlink/files/createbuildlink, keyword PKGUPPER
 >  -	ucPkgbase := strings.ToUpper(strings.Replace(pkgbase, "-", "_", -1))
 >  +
 >  +	tmp := strings.Replace(pkgbase, "-", "_", -1)
 >  +	tmp = strings.Replace(tmp, "+", "_", -1)
 >  +	tmp = strings.Replace(tmp, ".", "_", -1)
 >  +	ucPkgbase := strings.ToUpper(tmp)
 
 Currently pkglint does the same as createbuildlink (see the comment
 above the code), and I have no intention of changing that.
 
 And, by the way, + and . are perfectly legal in identifiers:
 
 ---snip---
 C++FLAGS+= -Wall -Wextra
 
 all:
         echo ${CXX} ${C++FLAGS}
 ---snip---
 
 Roland