Re: pkg/51061 (sysutils/duplicity update to 0.7.07)

[Frédéric Fauberteau <triaxx%triaxx.org@localhost>]

The following reply was made to PR pkg/51061; it has been noted by GNATS.

From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Fauberteau?= <triaxx%triaxx.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/51061 (sysutils/duplicity update to 0.7.07)
Date: Tue, 24 May 2016 20:39:37 +0000

 Le 2016-05-24 19:10, Benny Siegert a écrit :
 > The following reply was made to PR pkg/51061; it has been noted by 
 > GNATS.
 > 
 > From: Benny Siegert <bsiegert%NetBSD.org@localhost>
 > To: =?UTF-8?B?RnLDqWTDqXJpYyBGYXViZXJ0ZWF1?= <triaxx%triaxx.org@localhost>
 > Cc: gnats-bugs%netbsd.org@localhost
 > Subject: Re: pkg/51061 (sysutils/duplicity update to 0.7.07)
 > Date: Tue, 24 May 2016 21:06:50 +0200
 > 
 >  On Tue, May 24, 2016 at 9:02 PM, Benny Siegert <bsiegert%netbsd.org@localhost> 
 > wrote:
 >  > The egg-info lines in the PLIST should be using EGG_INFODIR.
 >  > Unfortunately, setuptools changes the "0.7.07.1" version into
 >  > "0.7.7.1". Do you have an idea why that could be?
 > 
 > 
 >  Another comment as I see this: The MESSAGE says:
 > 
 >  Depending on the storage backend used, additional packages might be 
 > needed:
 >  -Amazon S3 needs pkgsrc/net/py-boto.
 >  -Dropbox needs pkgsrc/net/py-dropbox.
 >  -For ssh/scp, pkgsrc/security/py-paramiko is recommended.
 > 
 >  How about just making them hard dependencies? They will make the
 >  package useful by default.
 
 Amazon S3 and dropbox dependencies could be parameterized in options.mk 
 but (1) it just had 5 python packages and (2) neither amazons3 nor 
 dropbox are in mk/default/options.descrition.
 
 The EGG_NAME variable you added seems to have no effect.
 
 How about this patch?
 
 Index: Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/sysutils/duplicity/Makefile,v
 retrieving revision 1.34
 diff -u -u -r1.34 Makefile
 --- Makefile  24 May 2016 19:10:46 -0000  1.34
 +++ Makefile  24 May 2016 20:31:31 -0000
 @@ -1,6 +1,7 @@
   # $NetBSD: Makefile,v 1.34 2016/05/24 19:10:46 bsiegert Exp $
 
   DISTNAME=  duplicity-0.7.07.1
 +PKGREVISION= 1
   CATEGORIES=  sysutils net
   MASTER_SITES=  
 http://code.launchpad.net/duplicity/0.7-series/${PKGVERSION_NOREV}/+download/
 
 @@ -14,6 +15,9 @@
   .include "options.mk"
 
   DEPENDS+=  ${PYPKGPREFIX}-lockfile>=0.9.1:../../devel/py-lockfile
 +DEPENDS+=  ${PYPKGPREFIX}-boto-[0-9]*:../../net/py-boto
 +DEPENDS+=  ${PYPKGPREFIX}-dropbox-[0-9]*:../../net/py-dropbox
 +DEPENDS+=  ${PYPKGPREFIX}-paramiko-[0-9]*:../../security/py-paramiko
 
   REPLACE_PYTHON+= bin/duplicity \
        bin/rdiffdir