pkg/51124: Update sysutils/smartmontools to 6.5

[nonakap%gmail.com@localhost]

>Number:         51124
>Category:       pkg
>Synopsis:       Update sysutils/smartmontools to 6.5
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun May 08 09:40:00 +0000 2016
>Originator:     Kimihiro Nonaka
>Release:        HEAD (20160507)
>Organization:
>Environment:
NetBSD koharu.myhome.nonakap.org 7.99.29 NetBSD 7.99.29 (KOHARU) #3633: Sat May  7 11:37:20 JST 2016  nonaka%koharu.myhome.nonakap.org@localhost:/home/storage/snapshot/NetBSD/HEAD-20160501/obj.NetBSD-amd64/amd64/sys/arch/amd64/compile/KOHARU amd64
>Description:
smartmontools 6.5 was released.

Date 2016-05-07
Summary: smartmontools release 6.5
-----------------------------------------------------------
- Experimental support for NVMe devices on FreeBSD, Linux and Windows.
- smartctl '-i', '-c', '-H' and '-l error': NVMe support.
- smartctl '-l nvmelog': New option for NVMe.
- smartd.conf '-H', '-l error' and '-W': NVMe support.
- Optional NVMe device scanning support on Linux and Windows.
- configure option '--with-nvme-devicescan' to include NVMe in
  default device scanning result.
- Device scanning now allows to specify multiple '-d TYPE' options.
- ATA: Added new POWER MODE values introduced in ATA ACS-2.
- ATA: SCT commands are no longer issued if ATA Security is locked.
- SCSI: LB provisioning improvements.
- SCSI: Fixed GLTSD bit set/cleared info messages.
- SCSI: Solid State media log page is no longer checked for tapes.
- SCSI: Improved handling when no tape cartridge in drive.
- SCSI: Workaround for buggy Seagate firmware.
- SAT: Improved heuristics to detect bogus sense data from SAT layer.
- smartd: Fixed crash on missing argument to '-s' directive.
- update-smart-drivedb: Now uses HTTPS for download by default.
- update-smart-drivedb: New options to select URL and download tool.
- update-smart-drivedb: New download tool 'svn'.
- configure option '--without-update-smart-drivedb' to disable
  update-smart-drivedb script.
- configure options '--disable-drivedb', '--enable-savestates',
  '--enable-attributelog' and '--with-docdir' are no longer supported.
- autoconf < 2.60 and automake < 1.10 are no longer supported.
- Drive database file now also includes the DEFAULT setting
  for each attribute.
- HDD, SSD and USB additions to drive database.
- Darwin: New support files for package installer.
  New makefile target 'install-darwin' builds DMG image.
- Solaris: Auto detection of SATA devices behind SAT layer.
- Solaris SPARC: Legacy ATA support disabled by default.
  New configure option '--with-solaris-sparc-ata' enables it.
  File os_solaris_ata.s is no longer included in source tarball.
- Windows: Auto detection of USB devices specified by drive letter.
- Windows: Device scanning does no longer ignore unknown USB devices.
- Windows: Prevent drive spin up by '-n standby' check.
- Windows: New application manifests indicating Win 10 support.
- Windows smartd: '-m [sys]msgbox' is no longer supported.
- Windows installer: Defaults to 64-bit version on 64-bit Windows.
- Various code changes suggested by Clang Static Analyser and Cppcheck.

>How-To-Repeat:

>Fix:
Please apply the following patch.

Index: sysutils/smartmontools/Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/smartmontools/Makefile,v
retrieving revision 1.28
diff -u -p -r1.28 Makefile
--- sysutils/smartmontools/Makefile	24 Sep 2015 22:30:29 -0000	1.28
+++ sysutils/smartmontools/Makefile	8 May 2016 06:49:07 -0000
@@ -1,6 +1,6 @@
 # $NetBSD: Makefile,v 1.28 2015/09/24 22:30:29 tnn Exp $
 
-DISTNAME=		smartmontools-6.4
+DISTNAME=		smartmontools-6.5
 CATEGORIES=		sysutils
 MASTER_SITES=		${MASTER_SITE_SOURCEFORGE:=smartmontools/}
 
@@ -26,7 +26,7 @@ CONF_FILES_PERMS=	${EGDIR}/smartd_warnin
 RCD_SCRIPTS=		smartd
 
 CONFIGURE_ARGS+=	--sysconfdir=${PKG_SYSCONFDIR}
-CONFIGURE_ARGS+=	--with-docdir=${PREFIX}/share/doc/smartmontools
+CONFIGURE_ARGS+=	--docdir=${PREFIX}/share/doc/smartmontools
 INSTALL_MAKE_FLAGS=	${MAKE_FLAGS} sysconfdir=${EGDIR}
 
 INSTALLATION_DIRS=	${EGDIR}
Index: sysutils/smartmontools/distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/smartmontools/distinfo,v
retrieving revision 1.26
diff -u -p -r1.26 distinfo
--- sysutils/smartmontools/distinfo	4 Nov 2015 01:32:31 -0000	1.26
+++ sysutils/smartmontools/distinfo	8 May 2016 06:49:07 -0000
@@ -1,9 +1,9 @@
 $NetBSD: distinfo,v 1.26 2015/11/04 01:32:31 agc Exp $
 
-SHA1 (smartmontools-6.4.tar.gz) = 855c7d555dd405e5b392b1631dc36dd9632db8b8
-RMD160 (smartmontools-6.4.tar.gz) = a90387c07488cfd3b1f87a34dcf9297983e174c5
-SHA512 (smartmontools-6.4.tar.gz) = 366cd55ec668da1ca8a3d9ba79d5bee6e0c59032936b7f2f161f8fbb1c9f869c505d715cc10562b6241f808bb8b534feaf9d9fd752f6cb1593ee893611742adc
-Size (smartmontools-6.4.tar.gz) = 822539 bytes
+SHA1 (smartmontools-6.5.tar.gz) = 7e788b429534a4ae627858fbcc826b93402cee7e
+RMD160 (smartmontools-6.5.tar.gz) = e62d15d406a92b75fa239603180c6b587f9d2aa8
+SHA512 (smartmontools-6.5.tar.gz) = dca7a6363ab7280ee4197155025f624c978886dcc94fc47b524f6f849138b62c471e966c0d4bf59c7bba50519dc122264618e5ded80a406863ddd10b43d928d3
+Size (smartmontools-6.5.tar.gz) = 855642 bytes
 SHA1 (patch-aa) = bd08aff267f0e9e9307ebc57858e61e35144bf16
-SHA1 (patch-ag) = bbf85278f08390d51ac9bb428ac7026763e5ffcf
-SHA1 (patch-os__netbsd.cpp) = 9c197ae492ef377d72df009be40d0abc1a827a31
+SHA1 (patch-ag) = 01b0b35d89d6d6a11b13b3c05a141c46a0c1590b
+SHA1 (patch-os__netbsd.cpp) = 28f78c08d7c7287165cfa38f8ee3467b3b03cb44
Index: sysutils/smartmontools/patches/patch-ag
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/smartmontools/patches/patch-ag,v
retrieving revision 1.5
diff -u -p -r1.5 patch-ag
--- sysutils/smartmontools/patches/patch-ag	12 Jun 2015 13:58:07 -0000	1.5
+++ sysutils/smartmontools/patches/patch-ag	8 May 2016 06:49:07 -0000
@@ -3,11 +3,11 @@ $NetBSD: patch-ag,v 1.5 2015/06/12 13:58
 Match x86 SunOS platforms correctly.
 Remove os_solaris=yes to avoid special man page section handling (PR 38199).
 
---- configure.orig	2014-07-26 09:50:18.000000000 +0000
-+++ configure
-@@ -6569,13 +6569,11 @@ fi
-   sparc-*-solaris*)
-     os_deps='os_solaris.o os_solaris_ata.o'
+--- configure.orig	2016-05-07 11:18:29.000000000 +0000
++++ configure	2016-05-08 06:41:03.000000000 +0000
+@@ -6659,13 +6659,11 @@ fi
+     test "$with_solaris_sparc_ata" = "yes" \
+       && os_deps="$os_deps os_solaris_ata.o"
      os_mailer='mailx'
 -    os_solaris=yes
      os_man_filter=Solaris
Index: sysutils/smartmontools/patches/patch-os__netbsd.cpp
===================================================================
RCS file: /cvsroot/pkgsrc/sysutils/smartmontools/patches/patch-os__netbsd.cpp,v
retrieving revision 1.2
diff -u -p -r1.2 patch-os__netbsd.cpp
--- sysutils/smartmontools/patches/patch-os__netbsd.cpp	8 Apr 2015 01:43:33 -0000	1.2
+++ sysutils/smartmontools/patches/patch-os__netbsd.cpp	8 May 2016 06:49:07 -0000
@@ -2,9 +2,9 @@ $NetBSD: patch-os__netbsd.cpp,v 1.2 2015
 
 Use a raw disk device file on NetBSD.
 
---- os_netbsd.cpp.orig	2013-03-29 20:17:03.000000000 +0000
-+++ os_netbsd.cpp
-@@ -57,7 +57,7 @@ printwarning(int msgNo, const char *extr
+--- os_netbsd.cpp.orig	2016-03-26 19:47:47.000000000 +0000
++++ os_netbsd.cpp	2016-05-08 06:45:25.000000000 +0000
+@@ -54,7 +54,7 @@ printwarning(int msgNo, const char *extr
    return;
  }
  
@@ -13,3 +13,12 @@ Use a raw disk device file on NetBSD.
  static const char *net_dev_ata_disk = "wd";
  static const char *net_dev_scsi_disk = "sd";
  static const char *net_dev_scsi_tape = "enrst";
+@@ -128,7 +128,7 @@ get_dev_names(char ***names, const char 
+     n++;
+   }
+ 
+-  void * tmp = (char **)realloc(mp, n * (sizeof(char *)));
++  char ** tmp = (char **)realloc(mp, n * (sizeof(char *)));
+   if (NULL == tmp) {
+     pout("Out of memory constructing scan device list\n");
+     free(mp);