pkgsrc-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: pkg/50987 (Support setting real work directory in pkg_comp)
The following reply was made to PR pkg/50987; it has been noted by GNATS.
From: Jan Danielsson <jan.m.danielsson%gmail.com@localhost>
To: Julio Merino <jmmv%meroh.net@localhost>, gnats-bugs%netbsd.org@localhost
Cc:
Subject: Re: pkg/50987 (Support setting real work directory in pkg_comp)
Date: Mon, 21 Mar 2016 22:36:08 +0100
This is a multi-part message in MIME format.
--------------000708030004030702090506
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
On 21/03/16 19:05, Julio Merino wrote:
> I think the patch looks good. A couple of nits:
>
> * Please sort the new entry in the manpage alphabetically (assuming
> the rest of the variables are sorted; I haven't checked).
They appear to be partially sorted alphabetically; the REAL_*
variables are grouped at the top and sorted amongst themselves -- I
followed that convention.
> * Bump the version number of pkg_comp.
Done.
--------------000708030004030702090506
Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0";
name="pkgcomp_realworkdir.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
filename="pkgcomp_realworkdir.diff"
SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L3BrZ3Ny
Yy9wa2d0b29scy9wa2dfY29tcC9NYWtlZmlsZSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41
NQpkaWZmIC11IC1yMS41NSBNYWtlZmlsZQotLS0gTWFrZWZpbGUJMjEgTm92IDIwMTUgMjM6
MTA6MjcgLTAwMDAJMS41NQorKysgTWFrZWZpbGUJMjEgTWFyIDIwMTYgMjE6MTg6NTggLTAw
MDAKQEAgLTEsNyArMSw2IEBACiAjICROZXRCU0Q6IE1ha2VmaWxlLHYgMS41NSAyMDE1LzEx
LzIxIDIzOjEwOjI3IGFnYyBFeHAgJAogCi1QS0dOQU1FPQlwa2dfY29tcC0xLjM4Ci1QS0dS
RVZJU0lPTj0JMQorUEtHTkFNRT0JcGtnX2NvbXAtMS4zOQogQ0FURUdPUklFUz0JcGtndG9v
bHMKIAogTUFJTlRBSU5FUj0Jam1tdkBOZXRCU0Qub3JnCkluZGV4OiBmaWxlcy9wa2dfY29t
cC44Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L3BrZ3NyYy9wa2d0b29scy9w
a2dfY29tcC9maWxlcy9wa2dfY29tcC44LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjQxCmRp
ZmYgLXUgLXIxLjQxIHBrZ19jb21wLjgKLS0tIGZpbGVzL3BrZ19jb21wLjgJMjEgTm92IDIw
MTUgMjM6MTA6MjcgLTAwMDAJMS40MQorKysgZmlsZXMvcGtnX2NvbXAuOAkyMSBNYXIgMjAx
NiAyMToxODo1OCAtMDAwMApAQCAtMjcsNyArMjcsNyBAQAogLlwiIEFSSVNJTkcgSU4gQU5Z
IFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQg
T0YgVEhFCiAuXCIgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAuXCIKLS5EZCBBdWd1
c3QgMTcsIDIwMTUKKy5EZCBNYXJjaCAyMSwgMjAxNgogLkR0IFBLR19DT01QIDgKIC5Pcwog
LlNoIE5BTUUKQEAgLTQ0MCw2ICs0NDAsOSBAQAogTW91bnQgb3B0aW9ucy4KIERlZmF1bHRz
IHRvCiAuU3kgLXQgbnVsbCAtbyBybyAuCisuSXQgUkVBTF9XT1JLRElSCitXaGVyZSB0byBz
dG9yZSBpbnRlcm1lZGlhdGUgYnVpbGQgdGFyZ2V0cyB3aGlsZSBidWlsZGluZyBwYWNrYWdl
cy4KK0RlZmF1bHRzIHRvIG5vdGhpbmcuCiAuSXQgTUFLRVJPT1RfSE9PS1MKIEEgd2hpdGVz
cGFjZSBzZXBhcmF0ZWQgbGlzdCBvZiBmdW5jdGlvbnMgb3IgZXh0ZXJuYWwgc2NyaXB0cyB0
byBiZSBleGVjdXRlZAogYWZ0ZXIgdGhlIHNhbmRib3ggaXMgY3JlYXRlZC4KSW5kZXg6IGZp
bGVzL3BrZ19jb21wLnNoCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnNyb290L3BrZ3Ny
Yy9wa2d0b29scy9wa2dfY29tcC9maWxlcy9wa2dfY29tcC5zaCx2CnJldHJpZXZpbmcgcmV2
aXNpb24gMS40MwpkaWZmIC11IC1yMS40MyBwa2dfY29tcC5zaAotLS0gZmlsZXMvcGtnX2Nv
bXAuc2gJMjEgTm92IDIwMTUgMjM6MTA6MjcgLTAwMDAJMS40MworKysgZmlsZXMvcGtnX2Nv
bXAuc2gJMjEgTWFyIDIwMTYgMjE6MTg6NTggLTAwMDAKQEAgLTUxLDcgKzUxLDggQEAKICAg
ICAgICAgICAgICAgICBSRUFMX1BBQ0tBR0VTIFJFQUxfUEFDS0FHRVNfT1BUUyBSRUFMX1BL
R1ZVTE5ESVIgXAogICAgICAgICAgICAgICAgIE5FVEJTRF9SRUxFQVNFIE1BS0VST09UX0hP
T0tTIE1PVU5UX0hPT0tTIFVNT1VOVF9IT09LUyBcCiAgICAgICAgICAgICAgICAgU1lOQ19V
TU9VTlQgQVVUT19UQVJHRVQgQVVUT19QQUNLQUdFUyBCVUlMRF9QQUNLQUdFUyBcCi0gICAg
ICAgICAgICAgICAgUkVBTF9DQ0FDSEUgTElCS1ZFUl9TVEFOREFMT05FX1BSRUZJWCBHRU5F
UkFURV9QS0dfU1VNTUFSWSIKKyAgICAgICAgICAgICAgICBSRUFMX0NDQUNIRSBMSUJLVkVS
X1NUQU5EQUxPTkVfUFJFRklYIEdFTkVSQVRFX1BLR19TVU1NQVJZIFwKKyAgICAgICAgICAg
ICAgICBSRUFMX1dPUktESVIiCiAKIF9CVUlMRF9SRVNVTUU9CiAKQEAgLTEyNiw2ICsxMjcs
NyBAQAogICAgIDogJHtTWU5DX1VNT1VOVDo9bm99CiAgICAgOiAke1JFQUxfQ0NBQ0hFOj19
CiAgICAgOiAke0dFTkVSQVRFX1BLR19TVU1NQVJZOj15ZXN9CisgICAgOiAke1JFQUxfV09S
S0RJUjo9fQogCiAgICAgaWYgWyAtbiAiJHtNQUtFX1BBQ0tBR0VTfSIgXTsgdGhlbgogICAg
ICAgICB3YXJuICJNQUtFX1BBQ0tBR0VTIGlzIGRlcHJlY2F0ZWQ7IHVzZSB7QVVUTyxCVUlM
RH1fUEFDS0FHRVMgaW5zdGVhZC4iCkBAIC0yODAsNiArMjgyLDE1IEBACiAgICAgICAgIG1v
dW50IC10IG51bGwgLW8gcncgJHtSRUFMX0NDQUNIRX0gJHtERVNURElSfS9wa2dfY29tcC9j
Y2FjaGUKICAgICBmaQogCisgICAgaWYgWyAtbiAiJHtSRUFMX1dPUktESVJ9IiBdOyB0aGVu
CisgICAgICAgIGlmIFsgISAtZCAiJHtSRUFMX1dPUktESVJ9IiBdOyB0aGVuCisgICAgICAg
ICAgICBlY2hvICIgZmFpbGVkLiIKKyAgICAgICAgICAgIGZzdW1vdW50CisgICAgICAgICAg
ICBlcnIgIlJFQUxfV09SS0RJUiAke1JFQUxfV09SS0RJUn0gZGlzYXBwZWFyZWQiCisgICAg
ICAgIGZpCisgICAgICAgIG1vdW50IC10IG51bGwgLW8gcncgJHtSRUFMX1dPUktESVJ9ICR7
REVTVERJUn0vcGtnX2NvbXAvb2JqCisgICAgZmkKKwogICAgIHRvdWNoICRmc3N0YXRlCiAK
ICAgICBpZiBbIC1uICIke01PVU5UX0hPT0tTfSIgXTsgdGhlbgpAQCAtMzQwLDYgKzM1MSwx
MCBAQAogICAgICAgICB1bW91bnQgJHtERVNURElSfS9wa2dfY29tcC9jY2FjaGUgfHwgZnNm
YWlsZWQ9eWVzCiAgICAgZmkKIAorICAgIGlmIFsgLW4gIiR7UkVBTF9XT1JLRElSfSIgLWEg
LWQgIiR7UkVBTF9XT1JLRElSfSIgXTsgdGhlbgorICAgICAgICB1bW91bnQgJHtERVNURElS
fS9wa2dfY29tcC9vYmogfHwgZnNmYWlsZWQ9eWVzCisgICAgZmkKKwogICAgIGlmIFsgIiRT
WU5DX1VNT1VOVCIgIT0gIm5vIiBdOyB0aGVuCiAgICAgICAgIHByaW50ZiAiU3luY2luZzog
MSIKICAgICAgICAgc3luYyA7IHNsZWVwIDEK
--------------000708030004030702090506--
Home |
Main Index |
Thread Index |
Old Index