pkg/50977: security/mit-krb5 fails to build on several systems

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         50977
>Category:       pkg
>Synopsis:       security/mit-krb5 fails to build on several systems
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 18 09:35:00 +0000 2016
>Originator:     Joern Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
I have informed tez already via PM.

Building the latest version of security/mit-krb5 fails for me on e.g. NetBSD 7.0/amd64 or Solaris 11.2/i86 with

making all in lib/crypto/builtin/aes...
[...]
bmake[4]: don't know how to make iaesx64.lo. Stop

>How-To-Repeat:

>Fix:
Although this is not even the problem for the failure above, as far as I can tell, configure does not check if AES-NI is actually supported, i.e. if compilation of iaesx64.s could technically succeed. A quick fix is

--- Makefile    2016/03/16 12:22:54     1.1
+++ Makefile    2016/03/16 12:37:23
@@ -45,6 +45,7 @@
 CONFIGURE_ARGS+=       --without-tcl
 CONFIGURE_ARGS+=       --enable-pkgsrc-libtool
 CONFIGURE_ARGS+=       --without-system-verto
+CONFIGURE_ARGS+=        --disable-aesni
 CONFIGURE_ENV+=                BUILDLINK_PREFIX_OPENSSL=${BUILDLINK_PREFIX.openssl:Q}
 CONFIGURE_ENV+=                DEFKTNAME=FILE:${PKG_SYSCONFDIR}/krb5.keytab
 MAKE_ENV+=             ROOT_USER=${ROOT_USER}

A better fix is maybe to make this a pkgsrc option (with default "false"). Or to fix this upstream...