Re: pkg/50753: pkg-config build failure with gcc6 defaults (linux)

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Tue, Feb 09, 2016 at 08:15:01PM +0000, coypu wrote:
>  --- /dev/null
>  +++ b/devel/glib2/patches/patch-glib_gdate.c
>  @@ -0,0 +1,18 @@
>  +$NetBSD$
>  +
>  +https://git.gnome.org/browse/glib/commit/?id=0817af40e8c74c721c30f6ef482b1f53d12044c7
>  +Merged upstream. Remove this in next release.
>  +
>  +--- glib/gdate.c.orig	2014-12-19 21:49:48.000000000 +0000
>  ++++ glib/gdate.c
>  +@@ -2494,7 +2494,10 @@ g_date_strftime (gchar       *s, 
>  +        * recognize whether strftime actually failed or just returned "".
>  +        */
>  +       tmpbuf[0] = '\1';
>  ++      #pragma GCC diagnostic push
>  ++      #pragma GCC diagnostic ignored "-Wformat-nonliteral"
>  +       tmplen = strftime (tmpbuf, tmpbufsize, locale_format, &tm);
>  ++      #pragma GCC diagnostic pop
>  + 
>  +       if (tmplen == 0 && tmpbuf[0] != '\0')
>  +         {

Please fill a GCC bug report for this. There is nothing unsafe about
using non-literal format strings with strftime.

Joerg