pkg/50776: databases/sqlite3 add mk/readline.buildlink3.mk to buildlink3.mk for devel/subversion-base

[davshao%gmail.com@localhost]

>Number:         50776
>Category:       pkg
>Synopsis:       databases/sqlite3 add mk/readline.buildlink3.mk to buildlink3.mk for devel/subversion-base
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 07 04:45:00 +0000 2016
>Originator:     David Shao
>Release:        pkgsrc current
>Organization:
>Environment:
FreeBSD xxxxx.xxx 11.0-CURRENT FreeBSD 11.0-CURRENT #0 r295345+b30e7ad(svn_head): Sat Feb  6 02:30:21 PST 2016     xxxxx%xxxxx.xxx@localhost:/usr/obj/usr/src/sys/GENERIC  amd64
>Description:
On FreeBSD 11-current amd64, with /usr/pkg/etc/mk.conf settings:

PREFER_PKGSRC=		yes
CURSES_DEFAULT=ncurses
READLINE_DEFAULT=readline

devel/subversion-base fails to build with:

cd subversion/libsvn_subr && /bin/sh "/usr/pkgsrc/devel/subversion-base/work/subversion-1.9.3/libtool" --tag=CC --silent --mode=link clang  -Werror=unknown-warning-option -g -I/usr/pkg/include -I/usr/pkg/include/apr-1 -I/usr/include   -g -I/usr/pkg/include -I/usr/pkg/include/apr-1 -I/usr/include  -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib  -L/usr/pkg/lib -L/usr/pkg/lib   -rpath /usr/pkg/lib -version-info 0  -o libsvn_subr-1.la  adler32.lo atomic.lo auth.lo base64.lo bit_array.lo cache-inprocess.lo cache-membuffer.lo cache-memcache.lo cache.lo cache_config.lo checksum.lo cmdline.lo compat.lo compress.lo config.lo config_auth.lo config_file.lo config_win.lo crypto.lo ctype.lo date.lo debug.lo deprecated.lo dirent_uri.lo dso.lo eol.lo error.lo fnv1a.lo gpg_agent.lo hash.lo io.lo iter.lo lock.lo log.lo macos_keychain.lo magic.lo md5.lo mergeinfo.lo mutex.lo nls.lo object_pool.lo opt.lo packed_data.lo path.lo pool.lo prefix_string.lo prompt.lo properties.lo quoprint.lo ro
 ot_pools.lo simple_providers.lo skel.lo sorts.lo spillbuf.lo sqlite.lo sqlite3wrapper.lo ssl_client_cert_providers.lo ssl_client_cert_pw_providers.lo ssl_server_trust_providers.lo stream.lo string.lo subst.lo sysinfo.lo target.lo temp_serializer.lo time.lo token.lo types.lo user.lo username_providers.lo utf.lo utf8proc.lo utf_validate.lo utf_width.lo validate.lo version.lo win32_crashrpt.lo win32_crypto.lo win32_xlate.lo x509info.lo x509parse.lo xml.lo -L/usr/pkg/lib -laprutil-1 -L/usr/pkg/lib -lapr-1 -lexpat -lz  -lsqlite3 -lmagic  -lintl -liconv
/usr/bin/ld: cannot find -lreadline
clang: error: linker command failed with exit code 1 (use -v to see invocation)


>How-To-Repeat:

>Fix:
Following the dependencies, for this group of settings in /usr/pkg/etc/mk.conf, there is a dependency on databases/sqlite3 which in turn depends on devel/readline.

In databases/sqlite3's Makefile there is an unconditional

.include "../../mk/readline.buildlink3.mk"

that does not appear in databases/sqlite3/buildlink3.mk

Using the following patch allows devel/subversion-base to build.

--- databases/sqlite3/buildlink3.orig	2015-04-06 12:08:53.000000000 -0700
+++ databases/sqlite3/buildlink3.mk	2016-02-06 20:14:19.710024000 -0800
@@ -16,6 +16,8 @@
 .include "../../textproc/icu/buildlink3.mk"
 .endif
 
+.include "../../mk/readline.buildlink3.mk"
+
 .endif # SQLITE3_BUILDLINK3_MK
 
 BUILDLINK_TREE+=	-sqlite3