pkg/50649: checkperms should probably not return error with -ff if all errors fixed

[richard%NetBSD.org@localhost]

>Number:         50649
>Category:       pkg
>Synopsis:       checkperms should probably not return error with -ff if all errors fixed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jan 11 20:30:00 +0000 2016
>Originator:     Richard PALO
>Release:        current
>Organization:
>Environment:
SunOS omnis 5.11 omnidev-0-g9705414 i86pc i386 i86pc

>Description:
as mentioned on pkgsrc-users@, it has been noticed that if
'checkperms -cff' is used, even if the protection errors detected
are fixed, an error is returned... which is not very intuitive.

an error should probably only be returned in this case if there
was a problem fixing the protection error, which in this case was no problem.
>How-To-Repeat:
richard@omnis:/home/richard/src/pkgsrc/devel/py-pyparsing$ bmake extract
=> Bootstrap dependency digest>=20010302: found digest-20121220
=> Checksum SHA1 OK for pyparsing-2.0.6.tar.gz
=> Checksum RMD160 OK for pyparsing-2.0.6.tar.gz
=> Checksum SHA512 OK for pyparsing-2.0.6.tar.gz
===> Installing dependencies for py27-pyparsing-2.0.6
==========================================================================
The following variables will affect the build process of this package,
py27-pyparsing-2.0.6.  Their current value is shown below:

        * PYTHON_VERSION_DEFAULT = 27

Based on these variables, the following variables have been set:

        * PYPACKAGE = python27

You may want to abort the process now with CTRL-C and change their value
before continuing.  Be sure to run `/opt/local/bin/bmake clean' after
the changes.
==========================================================================
=> Tool dependency pax>=20040802: found pax-20080110nb2
=> Tool dependency checkperms>=1.1: found checkperms-1.11
=> Build dependency cwrappers>=20150314: found cwrappers-20150707
=> Full dependency py27-setuptools>=0.8: found py27-setuptools-18.8
=> Full dependency python27>=2.7.1nb2: found python27-2.7.11
===> Overriding tools for py27-pyparsing-2.0.6
===> Extracting for py27-pyparsing-2.0.6
richard@omnis:/home/richard/src/pkgsrc/devel/py-pyparsing$ find /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/ -print | checkperms -cff
warning: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/dependency_links.txt: group-writable file.
error: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/dependency_links.txt: world-writable file.
note: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/dependency_links.txt: fixed permissions from 0666 to 0644.
warning: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/PKG-INFO: group-writable file.
error: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/PKG-INFO: world-writable file.
note: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/PKG-INFO: fixed permissions from 0666 to 0644.
warning: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/SOURCES.txt: group-writable file.
error: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/SOURCES.txt: world-writable file.
note: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/SOURCES.txt: fixed permissions from 0666 to 0644.
warning: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/top_level.txt: group-writable file.
error: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/top_level.txt: world-writable file.
note: /tmp/pkgsrc/devel/py-pyparsing/work/pyparsing-2.0.6/pyparsing.egg-info/top_level.txt: fixed permissions from 0666 to 0644.
4 errors and 4 warnings.
richard@omnis:/home/richard/src/pkgsrc/devel/py-pyparsing$ echo $?
1
>Fix: