Re: pkg/50019 (net/bmon shows tap(4) interface name with garbage at the end)

[David Holland <dholland-pbugs%netbsd.org@localhost>]

On Wed, Nov 04, 2015 at 05:40:00AM +0000, Dominik Bialy wrote:
 >  In file included from /usr/include/machine/lock.h:3:0,
 >                   from /usr/include/sys/lock.h:74,
 >                   from /usr/include/uvm/uvm_extern.h:472,
 >                   from /usr/include/sys/sysctl.h:49,
 >                   from in_sysctl.c:39:
 >  /usr/include/x86/lock.h:86:2: error: expected ')' before '__attribute__'
 >  /usr/include/x86/lock.h:86:2: error: expected ',' or ';' before ')' token
 >  /usr/include/x86/lock.h:88:2: error: expected ')' before '__attribute__'
 >  /usr/include/x86/lock.h:88:2: error: expected ',' or ';' before ')' token
 >  /usr/include/x86/lock.h:90:2: error: expected ')' before '__attribute__'
 >  /usr/include/x86/lock.h:90:2: error: expected ',' or ';' before ')' token
 >  /usr/include/x86/lock.h:92:2: error: expected ')' before '__attribute__'
 >  /usr/include/x86/lock.h:92:2: error: expected ',' or ';' before ')' token

That appears to be choking on __unused, which is odd...

 >  in_sysctl.c: In function 'sysctl_read':
 >  in_sysctl.c:229:3: warning: format '%u' expects type 'unsigned int', but argument 4 has type '__uint64_t'
 >  in_sysctl.c:229:3: warning: format '%u' expects type 'unsigned int', but argument 4 has type '__uint64_t'
 >  in_sysctl.c:232:3: warning: format '%u' expects type 'unsigned int', but argument 4 has type '__uint64_t'
 >  in_sysctl.c:232:3: warning: format '%u' expects type 'unsigned int', but argument 4 has type '__uint64_t'

(these should probably be patched)

 >  in_sysctl.c:235:59: error: 'struct if_data' has no member named 'ifi_recvquota'
 >  in_sysctl.c:238:59: error: 'struct if_data' has no member named 'ifi_xmitquota'

dunno about this.

 >  Also... One of the old patches you removed was, I think, to allow
 >  compilation with NetBSD sysctl headers.

I see a patch-src_in_sysctl.c from 2013, but it looks to be related to
the original problem in this PR - null termination of interface names.

-- 
David A. Holland
dholland%netbsd.org@localhost