pkg/50347: pkg-config 0.29 does not compile on Solaris

[joern.clausen%uni-bielefeld.de@localhost]

>Number:         50347
>Category:       pkg
>Synopsis:       pkg-config 0.29 does not compile on Solaris
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 19 14:05:00 +0000 2015
>Originator:     Joern Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
Solaris 11.2/i86, GCC 4.8.5
>Description:
The latest version 0.29 of devel/pkg-config does not compile on Solaris 11.2:

  CC       libglib_2_0_la-ggettext.lo
In file included from ggettext.c:30:0:
/usr/include/libintl.h:45:14: error: expected identifier or '(' before 'const'
 extern char *dcgettext(const char *, const char *, const int);
              ^

So let's try pkgsrc's gettext:

  CC       libglib_2_0_la-ggettext.lo
In file included from ggettext.c:30:0:
/opt/pkgsrc/pkg-hrz/pkgsrc/devel/pkg-config/work.pkgsrc-sol11i86/.buildlink/include/libintl.h:135:14: error: expected identifier or '(' before 'const'
 extern char *gettext (const char *__msgid)
              ^


After a successful build of pkg-config outside the pkgsrc tree, I wondered why this is used unconditionally in pkgsrc:

CONFIGURE_ARGS+=       --with-internal-glib

The build outside pkgsrc uses /usr/bin/pkg-config for bootstrapping and succeeds. Commenting out the line above in pkgsrc results in

checking if internal glib should be used... no
checking for GLIB... no
configure: error: Either a previously installed pkg-config or "glib-2.0 >= 2.16" could not be found. Please set GLIB_CFLAGS and GLIB_LIBS to the correct values or pass --with-internal-glib to configure to use the bundled copy.
*** Error code 1


Wouldn't be a check for a native pkg-config promise less trouble than unconditionally including a full blown glib?
>How-To-Repeat:

>Fix: