Re: pkg/50310: print/cups build fails with builtin heimdal

[Frédéric Fauberteau <frederic%fauberteau.org@localhost>]

The following reply was made to PR pkg/50310; it has been noted by GNATS.

From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Fauberteau?= <frederic%fauberteau.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/50310: print/cups build fails with builtin heimdal
Date: Sat, 10 Oct 2015 10:12:39 +0200

 Le 09/10/2015 10:55, Frédéric Fauberteau a écrit :
 > The following reply was made to PR pkg/50310; it has been noted by 
 > GNATS.
 > 
 > From: =?UTF-8?Q?Fr=C3=A9d=C3=A9ric_Fauberteau?= 
 > <frederic%fauberteau.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc:
 > Subject: Re: pkg/50310: print/cups build fails with builtin heimdal
 > Date: Fri, 09 Oct 2015 10:58:04 +0200
 > 
 >  Le 07/10/2015 14:20, frederic%fauberteau.org@localhost a écrit :
 >  >> Number:         50310
 >  >> Category:       pkg
 >  >> Synopsis:       print/cups build fails with builtin heimdal
 >  >> Confidential:   no
 >  >> Severity:       critical
 >  >> Priority:       medium
 >  >> Responsible:    pkg-manager
 >  >> State:          open
 >  >> Class:          sw-bug
 >  >> Submitter-Id:   net
 >  >> Arrival-Date:   Wed Oct 07 12:20:00 +0000 2015
 >  >> Originator:     Fr�d�ric Fauberteau
 >  >> Release:        pkgsrc-2015Q3
 >  >> Organization:
 >  >> Environment:
 >  > NetBSD trashware 6.1_STABLE NetBSD 6.1_STABLE (TRASHWARE) #0: Tue 
 > Jul
 >  > 7 09:13:34 CEST 2015
 >  >
 > triaxx@trashware:/home/triaxx/dev/nbsd/netbsd-6/obj/sys/arch/amd64/compile/TRASHWARE
 >  > amd64
 >  >> Description:
 >  > cups build fails on a link error due to missing krb5 libraries.
 > 
 >  More details:
 >  Actually, mit-krb5 was installed. Then configure script of cups find
 >  /usr/pkg/bin/krb5-config. But since pkgsrc detect heimdal from
 >  basesystem and KRB5_DEFAULT is set to heimdal, nothing is buildlinked
 >  into work/.buildlink.
 
 The cups configure script detects the krb5-config script of mit-krb5 
 whereas the basesystem heimdal implementation is present and 
 KRB5_DEFAULT is set to heimdal. pkgsrc detects the system heimdal 
 version since log shows that USE_BUILTIN.heimdal is set to yes. pkgsrc 
 exports the variable KRB5_CONFIG=/usr/bin/krb5-config.
 
 I am not really sure how to solve the problem but the following patch 
 correct it:
 Index: options.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/print/cups/options.mk,v
 retrieving revision 1.18
 diff -u -r1.18 options.mk
 --- options.mk  23 Aug 2014 20:02:11 -0000  1.18
 +++ options.mk  10 Oct 2015 07:09:28 -0000
 @@ -42,6 +42,9 @@
   .if !empty(PKG_OPTIONS:Mkerberos)
   .include "../../mk/krb5.buildlink3.mk"
   CONFIGURE_ARGS+= --enable-gssapi
 +.if !empty(USE_BUILTIN.heimdal:Myes)
 +CONFIGURE_ENV+=  KRB5CONFIG=/usr/bin/krb5-config
 +.endif
   .else
   CONFIGURE_ARGS+= --disable-gssapi
   .endif
 
 Maybe the following one is more adapted:
 $NetBSD$
 
 --- config-scripts/cups-gssapi.m4.orig  2014-06-10 13:54:53.000000000 
 +0000
 +++ config-scripts/cups-gssapi.m4
 @@ -22,8 +22,8 @@ LIBGSSAPI=""
   AC_SUBST(LIBGSSAPI)
 
   if test x$enable_gssapi != xno; then
 - AC_PATH_TOOL(KRB5CONFIG, krb5-config)
 - if test "x$KRB5CONFIG" != x; then
 + AC_PATH_TOOL(KRB5_CONFIG, krb5-config)
 + if test "x$KRB5_CONFIG" != x; then
      case "$uname" in
        Darwin)
          # OS X weak-links to the Kerberos framework...
 @@ -40,15 +40,15 @@ if test x$enable_gssapi != xno; then
          # Solaris has a non-standard krb5-config, don't use it!
          AC_CHECK_LIB(gss, gss_display_status,
            AC_DEFINE(HAVE_GSSAPI, 1, [Whether GSSAPI is available])
 -         CFLAGS="`$KRB5CONFIG --cflags` $CFLAGS"
 -         CPPFLAGS="`$KRB5CONFIG --cflags` $CPPFLAGS"
 -         LIBGSSAPI="-lgss `$KRB5CONFIG --libs`")
 +         CFLAGS="`$KRB5_CONFIG --cflags` $CFLAGS"
 +         CPPFLAGS="`$KRB5_CONFIG --cflags` $CPPFLAGS"
 +         LIBGSSAPI="-lgss `$KRB5_CONFIG --libs`")
          ;;
        *)
          # Other platforms just ask for GSSAPI
 -       CFLAGS="`$KRB5CONFIG --cflags gssapi` $CFLAGS"
 -       CPPFLAGS="`$KRB5CONFIG --cflags gssapi` $CPPFLAGS"
 -       LIBGSSAPI="`$KRB5CONFIG --libs gssapi`"
 +       CFLAGS="`$KRB5_CONFIG --cflags gssapi` $CFLAGS"
 +       CPPFLAGS="`$KRB5_CONFIG --cflags gssapi` $CPPFLAGS"
 +       LIBGSSAPI="`$KRB5_CONFIG --libs gssapi`"
          ;;
      esac
      AC_DEFINE(HAVE_GSSAPI, 1, [Whether GSSAPI is available])