pkg/50272: www/nginx fails to build when option "upload" is enabled

[Timshel Knoll-Miller <timshel%shels.net@localhost>]

>Number:         50272
>Category:       pkg
>Synopsis:       www/nginx fails to build when option "upload" is enabled
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 24 00:30:00 +0000 2015
>Originator:     Timshel Knoll-Miller <timshel%shels.net@localhost>
>Release:        NetBSD 7.0_RC3, pkgsrc HEAD at 2015-09-23
>Organization:
>Environment:
System: NetBSD urchin.manna.shels.net 7.0_RC3 NetBSD 7.0_RC3 (BPI) #1: Thu Sep 10 22:45:34 AEST 2015 root@netbsd.localdomain:/usr/obj/sys/arch/evbarm/compile/BPI evbarm
Architecture: earmv7hf
Machine: evbarm

[root@urchin nginx]# make show-options
...
These options are currently enabled:
	dav flv inet6 memcache pcre perl ssl status
	upload
...

>Description:
Nginx package build fails with the below error when PKG_OPTIONS.nginx contains the "upload" option. This is a known issue with the Nginx upload module - it doesn't work with Nginx >= 1.3.8 and the module seems to be unmaintained. See https://github.com/vkholodkov/nginx-upload-module/issues/41 for a long discussion thread. Given this, should the "upload" option be be removed from pkgsrc (at least until someone decides to maintain nginx-upload-module?)

....
gcc -c -O2 -I/usr/include -I/usr/pkg/include -I src/core  -I src/event  -I src/event/modules  -I src/os/unix  -I objs -I src/http  -I src/http/modules  -I src/http/modules/perl  -o objs/src/http/modules/ngx_http_stub_status_module.o  src/http/modules/ngx_http_stub_status_module.c
gcc -c -O2 -I/usr/include -I/usr/pkg/include  -I src/core  -I src/event  -I src/event/modules  -I src/os/unix  -I objs  -I src/http  -I src/http/modules  -I src/http/modules/perl  -I src/mail  -o objs/addon/nginx_upload_module-2.2.0/ngx_http_upload_module.o  ../nginx_upload_module-2.2.0/ngx_http_upload_module.c
../nginx_upload_module-2.2.0/ngx_http_upload_module.c: In function 'ngx_http_read_upload_client_request_body':
../nginx_upload_module-2.2.0/ngx_http_upload_module.c:2628:15: error: 'ngx_http_request_body_t' has no member named 'to_write'
             rb->to_write = rb->bufs;
               ^
../nginx_upload_module-2.2.0/ngx_http_upload_module.c:2687:7: error: 'ngx_http_request_body_t' has no member named 'to_write'
     rb->to_write = rb->bufs;
       ^
../nginx_upload_module-2.2.0/ngx_http_upload_module.c: In function 'ngx_http_do_read_upload_client_request_body':
../nginx_upload_module-2.2.0/ngx_http_upload_module.c:2769:57: error: 'ngx_http_request_body_t' has no member named 'to_write'
                 rc = ngx_http_process_request_body(r, rb->to_write);
                                                         ^
../nginx_upload_module-2.2.0/ngx_http_upload_module.c:2785:19: error: 'ngx_http_request_body_t' has no member named 'to_write'
                 rb->to_write = rb->bufs->next ? rb->bufs->next : rb->bufs;
                   ^
../nginx_upload_module-2.2.0/ngx_http_upload_module.c:2877:45: error: 'ngx_http_request_body_t' has no member named 'to_write'
     rc = ngx_http_process_request_body(r, rb->to_write);
                                             ^
*** Error code 1

Stop.
make[1]: stopped in /tmp/work/www/nginx/work.earmv7hf/nginx-1.8.0
*** Error code 1

Stop.
make: stopped in /tmp/work/www/nginx/work.earmv7hf/nginx-1.8.0
*** Error code 1

Stop.
make[1]: stopped in /stg/src/pkgsrc/pkgsrc-2015Q2/www/nginx
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/www/nginx
[root@urchin nginx]# 

>How-To-Repeat:
Add PKG_OPTIONS.nginx+=upload to your /etc/mk.conf and run "make package" in the pkgsrc/www/nginx folder.
>Fix:
Patch nginx-upload-module to work with nginx > 1.3.8; or remove "upload" build option from pkgsrc?