Re: pkg/50214: devel/cmake USE_NCURSES considered harmful

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Mon, Sep 07, 2015 at 02:30:00AM +0000, davshao%gmail.com@localhost wrote:
> diff -Nurb cmake.orig/CVS/Entries.Log cmake/CVS/Entries.Log
> --- cmake.orig/CVS/Entries.Log	2015-09-06 17:48:04.899568000 -0700
> +++ cmake/CVS/Entries.Log	1969-12-31 16:00:00.000000000 -0800
> @@ -1 +0,0 @@
> -A D/patches////
> diff -Nurb cmake.orig/Makefile cmake/Makefile
> --- cmake.orig/Makefile	2015-08-20 04:35:33.000000000 -0700
> +++ cmake/Makefile	2015-08-28 22:16:39.608277000 -0700
> @@ -13,7 +13,6 @@
>  
>  USE_TOOLS+=		gmake
>  USE_LANGUAGES=		c c++
> -USE_NCURSES=		yes
>  HAS_CONFIGURE=		yes
>  CONFIGURE_SCRIPT=	bootstrap
>  
> @@ -31,6 +30,10 @@
>  
>  .include "../../mk/bsd.prefs.mk"
>  
> +.if ${OPSYS} != "FreeBSD" && ${OPSYS} != "DragonFly"
> +USE_NCURSES=		yes
> +.endif
> +
>  .if !empty(MAKE_JOBS)
>  CONFIGURE_ARGS+=	--parallel=${MAKE_JOBS:Q}
>  .endif

This patch is completely wrong. If the systems ship a ncurses in base,
make sure the builtin.mk logic can detect that properly.

Joerg