Re: pkg/50188: pkgtools/pkg_install DragonFly 4.3 /usr/lib/libbz2.so.2: error adding symbols

[David Shao <davshao%gmail.com@localhost>]

The following reply was made to PR pkg/50188; it has been noted by GNATS.

From: David Shao <davshao%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/50188: pkgtools/pkg_install DragonFly 4.3 /usr/lib/libbz2.so.2:
 error adding symbols
Date: Wed, 2 Sep 2015 13:31:23 -0700

 > From: Thomas Klausner <wiz%NetBSD.org@localhost>
 
 >
 >  This looks like "-lbz2" should be on the link line. Can you add this manually and try again?
 >   Thomas
 
 I can get the build to finish using something similar to this
 suggestion, but I dare not replace pkg_install due to some still
 apparently implicitly defined functions.
 
 Also there is another problem:  I can't get the flags -lbz2 -lz to be
 recognized unless I manually enter them into the respective lines in
 Makefile.in's.  But there needs to be flexibility for systems either
 with or without a base libbz2 and libz.
 
 In other words, in the pkgtools/pkg_install Makefile, neither
 
 LDFLAGS+= -lbz2 -lz
 
 nor
 
 LIBS+= -lbz2 -lz
 
 are recognized in lines similar to
 
 cc -lssl -lcrypto -L/usr/pkgsrc/pkgtools/pkg_install/work/libfetch
 -L/usr/pkgsrc/pkgtools/pkg_install/work/netpgpverify
 -L/usr/pkgsrc/pkgtools/pkg_install/work/libnbcompat -L/usr/lib
 -Wl,-R/usr/lib -Wl,-R/usr/pkg/lib -L../lib -o pkg_info main.o
 perform.o show.o -linstall -larchive -lfetch -lnetpgpverify -lnbcompat
 -lssl -lcrypto -lbz2 -lz
 
 I wonder if there needs to be a common Makefile.common so that instead
 of just copying files, constructs such as LDFLAGS and LIBS are
 properly replaced.
 
 And the following make me nervous about replacing the package pkg_install:
 
 checking md5.h usability... yes
 checking md5.h presence... yes
 checking for md5.h... yes
 checking for MD5Init in md5.h... yes
 checking for md5.h... (cached) yes
 checking rmd160.h usability... yes
 checking rmd160.h presence... yes
 checking for rmd160.h... yes
 checking sha1.h usability... no
 checking sha1.h presence... no
 checking for sha1.h... no
 checking sha2.h usability... no
 checking sha2.h presence... no
 checking for sha2.h... no
 checking for MD5File... no
 checking for RMD160File... no
 checking for SHA1File... no
 checking for SHA512_File... no
 ...
 
 cc -D_LARGEFILE_SOURCE -D_LARGE_FILES -D_FILE_OFFSET_BITS=64
 -DDEF_UMASK=0022 -I/usr/pkgsrc/pkgtools/pkg_install/work/libfetch
 -I/usr/pkgsrc/pkgtools/pkg_install/work -DHAVE_NBCOMPAT_H=1
 -I/usr/pkgsrc/pkgtools/pkg_install/work/libnbcompat -I/usr/include
 -D__DBINTERFACE_PRIVATE -I. -I.  -g -I/usr/include -DHAVE_CONFIG_H -c
 unvis.c
 unvis.c: In function 'unvis':
 unvis.c:92:9: warning: implicit declaration of function
 '__nbcompat_unvis13' [-Wimplicit-function-declaration]
   return __nbcompat_unvis13(cp, (int)c, astate, flag);
          ^
 ...
 cc -g -I/usr/include -D_LARGEFILE_SOURCE -D_LARGE_FILES
 -D_FILE_OFFSET_BITS=64 -DDEF_UMASK=0022
 -I/usr/pkgsrc/pkgtools/pkg_install/work/libfetch
 -I/usr/pkgsrc/pkgtools/pkg_install/work -DHAVE_NBCOMPAT_H=1
 -I/usr/pkgsrc/pkgtools/pkg_install/work/libnbcompat -I/usr/include -c
 digest.c
 digest.c: In function 'digest_init':
 digest.c:131:3: warning: implicit declaration of function 'RMD160Init'
 [-Wimplicit-function-declaration]
    RMD160Init(&hash->u.rmd160ctx);
    ^
 digest.c: In function 'digest_update':
 digest.c:215:3: warning: implicit declaration of function
 'RMD160Update' [-Wimplicit-function-declaration]
    RMD160Update(hash->ctx, data, (unsigned)length);
    ^
 digest.c: In function 'digest_final':
 digest.c:247:3: warning: implicit declaration of function
 'RMD160Final' [-Wimplicit-function-declaration]
    RMD160Final(out, hash->ctx);
    ^
 digest.c:253:3: warning: implicit declaration of function
 'netpgpv_SHA512_Final' [-Wimplicit-function-declaration]
    netpgpv_SHA512_Final(out, hash->ctx);
    ^