Re: pkg/49961: Properly handle bash shell in print/cups-filters

[Aleksej Saushev <asau%inbox.ru@localhost>]

The following reply was made to PR pkg/49961; it has been noted by GNATS.

From: Aleksej Saushev <asau%inbox.ru@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: pkg/49961: Properly handle bash shell in print/cups-filters
Date: Thu, 11 Jun 2015 08:04:12 +0300

 Leonardo Taccari <iamleot%gmail.com@localhost> writes:
 
 > Index: Makefile
 > ===================================================================
 > RCS file: /cvsroot/pkgsrc/print/cups-filters/Makefile,v
 > retrieving revision 1.20
 > diff -u -r1.20 Makefile
 > --- Makefile	25 Apr 2015 14:24:45 -0000	1.20
 > +++ Makefile	10 Jun 2015 14:47:54 -0000
 > @@ -24,6 +24,12 @@
 >  
 >  REPLACE_BASH+=	filter/textonly
 >  
 > +SUBST_CLASSES+=		bash
 > +SUBST_STAGE.bash=	pre-build
 > +SUBST_MESSAGE.bash=	Fixing bash PATH.
 > +SUBST_FILES.bash=	filter/foomatic-rip/foomaticrip.c
 > +SUBST_SED.bash=		-e 's,/bin/bash,${TOOLS_PATH.bash},g'
 > +
 >  CONFIGURE_ARGS+=	--with-rcdir=${PREFIX}/share/examples/rc.d
 >  CONFIGURE_ARGS+=	--with-rclevels=""
 
 This sounds as a step for another phase, either patch or configure,
 thus it should be post-patch or pre- or post-configure rather.
 
 Because of the above, could you consider adding it as a configuration parameter?
 Perhaps just CPPFLAGS is enough. Configuration parameter could be easier accepted upstream.