Re: pkg/49782 (textproc/mdocml won't build on Solaris)

[David Holland <dholland-pbugs%netbsd.org@localhost>]

The following reply was made to PR pkg/49782; it has been noted by GNATS.

From: David Holland <dholland-pbugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: Christos Zoulas <christos%netbsd.org@localhost>
Subject: Re: pkg/49782 (textproc/mdocml won't build on Solaris)
Date: Thu, 28 May 2015 19:57:31 +0000

 On Wed, Apr 08, 2015 at 01:20:01AM +0000, Christos Zoulas wrote:
  >  |  No good.  The patch is looking for __sun__, not __sun.
  >  |  
  >  |  +#ifdef __sun__
  >  |  
  >  |  should be
  >  |  
  >  |  +#ifdef __sun
  >  |  
  >  |  in patch-compat_fts.c.
  >  
  >  This is compiler-dependent. You should check for either like:
  >  
  >      #if defined(__sun) || defined(__sun__)
  >  
  >  to be safe...
 
 pkglint has been telling us for years to use only __sun; is that
 wrong?
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost