Re: pkg/49878: xfe fails to build

[Leonardo Taccari <iamleot%gmail.com@localhost>]

The following reply was made to PR pkg/49878; it has been noted by GNATS.

From: Leonardo Taccari <iamleot%gmail.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/49878: xfe fails to build
Date: Wed, 06 May 2015 20:14:30 +0200

 Hello Paul and the entire pkgsrc community,
 
 hponeill%me.com@localhost writes:
 > [...]
 > >Environment:
 > NetBSD 6.1.2 (GENERIC) i386
 > >Description:
 > trying to build xfe results in the configure error =
 
 > ftheader.h not found
 > =
 
 > ftheader is part of the freetype2 package
 > >How-To-Repeat:
 > try to build xfe from source
 > >Fix:
 > editing the configure script line 4235
 > =
 
 > change "config/ftheader.h"
 > to "freetype/config/ftheader.h"
 > =
 
 > will allow xfe to build but this may not be an appropriate fix.
 I have investigated a bit regarding this problem... Looking at the xfe
 changelog it seems that they discussed and applied the change in xfe bug
 #192:
 
  http://sourceforge.net/p/xfe/bugs/192/
 
 The problem affects older version of freetype2 (e.g. here on
 NetBSD-current and also on NetBSD 7.0_BETA the path for ftheader.h is
 correct). But as you pointed out it still works also with older version
 of freetype2 so IMHO we should not force to depends on pkgsrc version
 graphics/freetype2. Also bump PKGREVISION.
 
 I will attach patches to fix this issue inline in this email. While here
 I have also added LICENSE and squashed various pkgtools/pkglint
 warnings.
 
 
 Paul, can you try it and let us know if it works correctly please (I
 have only tested it on NetBSD-current and pkgsrc-current)?
 
 
 Ciao,
 L.
 
 
 -------------------8<-----------------8<-----------------8<---------------=
 ----
 Index: Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/sysutils/xfe/Makefile,v
 retrieving revision 1.48
 diff -u -r1.48 Makefile
 --- Makefile	25 Apr 2015 14:24:56 -0000	1.48
 +++ Makefile	6 May 2015 18:12:03 -0000
 @@ -1,13 +1,14 @@
  # $NetBSD: Makefile,v 1.48 2015/04/25 14:24:56 tnn Exp $
  =
 
  DISTNAME=3D	xfe-1.40
 -PKGREVISION=3D	1
 +PKGREVISION=3D	2
  CATEGORIES=3D	sysutils
  MASTER_SITES=3D	${MASTER_SITE_SOURCEFORGE:=3Dxfe/}
  =
 
  MAINTAINER=3D	pkgsrc-users%NetBSD.org@localhost
  HOMEPAGE=3D	http://roland65.free.fr/xfe/
  COMMENT=3D	Fast MS-Explorer like filemanager for X
 +LICENSE=3D	gnu-gpl-v2
  =
 
  USE_LANGUAGES=3D		c c++
  USE_PKGLOCALEDIR=3D	yes
 @@ -25,6 +26,7 @@
  =
 
  .include "../../converters/libiconv/buildlink3.mk"
  .include "../../devel/gettext-lib/buildlink3.mk"
 +.include "../../sysutils/desktop-file-utils/desktopdb.mk"
  .include "../../x11/fox/buildlink3.mk"
  .include "../../mk/pthread.buildlink3.mk"
  .include "../../mk/bsd.pkg.mk"
 Index: distinfo
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/sysutils/xfe/distinfo,v
 retrieving revision 1.12
 diff -u -r1.12 distinfo
 --- distinfo	15 Feb 2015 14:09:38 -0000	1.12
 +++ distinfo	6 May 2015 18:12:03 -0000
 @@ -4,5 +4,5 @@
  RMD160 (xfe-1.40.tar.gz) =3D a2add3bdac71706da9ea791d88bc96cbcdc3afb3
  Size (xfe-1.40.tar.gz) =3D 2574477 bytes
  SHA1 (patch-ac) =3D 001140df584ef01d52e0737a57e0babbc574a0b4
 -SHA1 (patch-configure) =3D 1eb11db5286e4cf3b3829a5a2370c9d4acb2d1a5
 +SHA1 (patch-configure) =3D 406757b915cbd266bc9e4dfd2402f6676c976ee6
  SHA1 (patch-src_main.cpp) =3D 2e875f4235b7e4c22ad5a0c236144bdd549fb8a1
 Index: patches/patch-configure
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /cvsroot/pkgsrc/sysutils/xfe/patches/patch-configure,v
 retrieving revision 1.1
 diff -u -r1.1 patch-configure
 --- patches/patch-configure	15 Feb 2015 14:09:38 -0000	1.1
 +++ patches/patch-configure	6 May 2015 18:12:03 -0000
 @@ -1,8 +1,24 @@
 -$NetBSD: patch-configure,v 1.1 2015/02/15 14:09:38 ryoon Exp $
 +$NetBSD$
 +
 +o Older freetype2 versions have a different path for ftheader.h, also che=
 ck for
 +  it in order to avoid forcing dependency to the pkgsrc version of
 +  graphics/freetype2. For more information please give a look to pkg/4987=
 8.
 +o test(1) does not support the "=3D=3D" operator. Use the "=3D" operator =
 to compare if
 +  two strings are identical.
  =
 
  --- configure.orig	2014-12-05 14:51:58.000000000 +0000
  +++ configure
 -@@ -16194,7 +16194,7 @@ echo "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 +@@ -14233,7 +14233,9 @@ done
 + 	  CPPFLAGS=3D"$freetype_cflags $CPPFLAGS"
 + 	fi
 + 	ac_fn_cxx_check_header_mongrel "$LINENO" "config/ftheader.h" "ac_cv_hea=
 der_config_ftheader_h" "$ac_includes_default"
 ++	ac_fn_cxx_check_header_mongrel "$LINENO" "freetype/config/ftheader.h" "=
 ac_cv_header_freetype_config_ftheader_h" "$ac_includes_default"
 + if test "x$ac_cv_header_config_ftheader_h" =3D xyes; then :
 ++elif test "x$ac_cv_header_freetype_config_ftheader_h" =3D xyes; then :
 + =
 
 + else
 +   as_fn_error $? "\"ftheader.h not found\"" "$LINENO" 5
 +@@ -16194,7 +16196,7 @@ echo "=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
   =
 
   =
 
   # Warning message about Xft support