pkg/49852: net/socat on Darwin/MacOS X build wrongly fails due to "No acceptable compiler found"

[alex-b%opus-b.com@localhost]

>Number:         49852
>Category:       pkg
>Synopsis:       net/socat on Darwin/MacOS X build wrongly fails due to "No acceptable compiler found"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr 24 15:35:00 +0000 2015
>Originator:     Alexander Borkowski
>Release:        pkgsrc-2015Q1 2015-04-25
>Organization:
>Environment:
Darwin nostromo.opus-b.com 11.4.2 Darwin Kernel Version 11.4.2: Thu Aug 23 16:25:48 PDT 2012; root:xnu-1699.32.7~1/RELEASE_X86_64 x86_64
>Description:
A build attempt of net/socat on Darwin/MacOS X aborts with the following messages:

ERROR: This package is only available for these compilers: gcc.
ERROR: This package has set PKG_FAIL_REASON:
ERROR: No acceptable compiler found for socat-1.7.2.4.

The reason is that in the Makefile for that package it says:

ONLY_FOR_COMPILER= gcc # uses -Werror in the configure script

and bootstrap set

PKGSRC_COMPILER= clang

in etc/mk.conf.

I manually added clang to ONLY_FOR_COMPILER in the Makefile and the package builds, installs and works ok so far. Regarding the -Werror comment, clang has that as well.
>How-To-Repeat:
Attempt to build pkgsrc package net/socat on Darwin/MacOS X.

>Fix:
Edit pkgsrc package net/socat Makefile to add clang to the ONLY_FOR_COMPILER variable.