Re: pkg/49770: update archive/gsharutils to 4.15, make tests pass

[HIRAMATSU Yoshifumi <hiramatsu%NetBSD.org@localhost>]

The following reply was made to PR pkg/49770; it has been noted by GNATS.

From: HIRAMATSU Yoshifumi <hiramatsu%NetBSD.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: pkg/49770: update archive/gsharutils to 4.15, make tests pass
Date: Mon, 06 Apr 2015 01:05:58 +0900

 Hello,
 
 On Sun, 22 Mar 2015 05:25:00 +0900,
 > The attached patch:
 > 
 > - updates archivers/gsharutils to 4.15 from 4.13.5
 > - changes distinfo to use SHA256 instead of SHA1
 > - removes --disable-uucode from configure options
 > 
 > The last point merits a bit more explanation. With --disable-uucode given, the tests fail. I wasn't able to find a reason for including --disable-uucode in Makefile's CVS history. If there's a good reason it should be there, feel free to close out the PR and I'll create a new one without that change.
 
 Thank you for creating this patch, I'm going to commit it in a few days.
 
 I will change two points, however.
 
 1. I will use SHA1 checksum.
 
    SHA256 is considered better than SHA1 because of collision probability,
    and pkgsrc accepts SHA256.
    But other packages use SHA1, I will use SHA1 for consistency.
 
 2. PLIST needs update too.
 
    Because we will enable uuencode, PLIST also should be updated.
 
    kjw, do you define "PKG_DEVELOPER=yes" in your mk.conf?
    When you have PKG_DEVELOPER=yes pkgsrc performs sanity checks during
    build and install, and I noticed the PLIST issue by the checks.
 
    If you work on more packages, it will really help.
 
 Kind regards,
 HIRAMATSU, Yoshifumi