Re: pkg/49755: net/dnscheck package needs devel/p5-List-MoreUtils to run

[Adrien Auzanneau <ada%netbsdfr.org@localhost>]

Suggested changes to net/dnscheck/Makefile (removing patches/ as well)


7c7
< MASTER_SITES= -https://github.com/dotse/dnscheck/tarball/1.5.4
---
> MASTER_SITES=   ${MASTER_SITE_GITHUB:=dotse/dnscheck/tarball/1.5.4/}
33a34
> DEPENDS+=       p5-List-MoreUtils-[0-9]*:../../devel/p5-List-MoreUtils
41,48d41
<
< WRKSRC=         ${WRKDIR}/dotse-dnscheck-006ca8d/engine
< SYSCONFDIR=     `${BASENAME} ${PKG_SYSCONFDIR}`
<
< EGDIR=                ${PREFIX}/share/examples/${PKGBASE}
< #CONF_FILES=  ${EGDIR}/config.yaml 
${PKG_SYSCONFDIR}/${PKGBASE}/config.yaml
< #CONF_FILES+= ${EGDIR}/policy.yaml 
${PKG_SYSCONFDIR}/${PKGBASE}/policy.yaml
<
50a44,46
> INSTALLATION_DIRS=    ${EGDIR}
> OWN_DIRS=             ${PKGSYSCONFDIR} ${PKGBASE}
54,57c50
< SUBST_SED.paths+=       -e s!@SYSCONFDIR@!${SYSCONFDIR}!g
<
< INSTALLATION_DIRS=    ${EGDIR}
< OWN_DIRS=             ${SYSCONFDIR}/${PKGBASE}
---
> SUBST_SED.paths+=       -e s!/etc!${PKGSYSCONFDIR}!g
59,60c52,53
< post-patch:
<       ${RM} ${WRKSRC}/lib/DNSCheck/Config.pm.orig
---
> WRKSRC=         ${WRKDIR}/dotse-dnscheck-006ca8d/engine
> EGDIR=                ${PREFIX}/share/examples/${PKGBASE}
62,64c55,56
< #post-install:
< #     ${INSTALL_DATA} ${WRKSRC}/config.yaml ${DESTDIR}${EGDIR}/
< #     ${INSTALL_DATA} ${WRKSRC}/policy.yaml ${DESTDIR}${EGDIR}/
---
> post-install:
>       ${MV} ${WRKSRC}/config ${EGDIR}




On 2015-03-18 13:40, dogan%tesmer.org.tr@localhost wrote:
> > Number:         49755
> > Category:       pkg
> > Synopsis:       net/dnscheck package needs devel/p5-List-MoreUtils to 
> > run
> > Confidential:   no
> > Severity:       serious
> > Priority:       low
> > Responsible:    pkg-manager
> > State:          open
> > Class:          sw-bug
> > Submitter-Id:   net
> > Arrival-Date:   Wed Mar 18 12:40:00 +0000 2015
> > Originator:     Mustafa Dogan
> > Release:        NetBSD 7.0_BETA (GENERIC) amd64 Mar 12 2015
> > Organization:
> Ankara University
> > Environment:
> NetBSD research 7.0_BETA NetBSD 7.0_BETA (GENERIC) #0: Thu Mar 12
> 06:11:39 EET 2015
> root@localhost:/root/OBJ/sys/arch/amd64/compile/GENERIC amd64
> > Description:
> net/dnscheck package can be compiled but require
> devel/p5-List-MoreUtils to run. Otherwise, you will see on screen:
>
> Can't locate List/MoreUtils.pm in @INC (you may need to install the
> List::MoreUtils module) (@INC contains:
> /usr/pkg/lib/perl5/site_perl/5.20.0/x86_64-netbsd-thread-multi
> /usr/pkg/lib/perl5/site_perl/5.20.0
> /usr/pkg/lib/perl5/vendor_perl/5.20.0/x86_64-netbsd-thread-multi
> /usr/pkg/lib/perl5/vendor_perl/5.20.0
> /usr/pkg/lib/perl5/5.20.0/x86_64-netbsd-thread-multi
> /usr/pkg/lib/perl5/5.20.0 .) at
> /usr/pkg/lib/perl5/vendor_perl/5.20.0/DNSCheck/Test/Zone.pm line 40.
> BEGIN failed--compilation aborted at
> /usr/pkg/lib/perl5/vendor_perl/5.20.0/DNSCheck/Test/Zone.pm line 40.
> Compilation failed in require at
> /usr/pkg/lib/perl5/vendor_perl/5.20.0/DNSCheck.pm line 51.
> BEGIN failed--compilation aborted at
> /usr/pkg/lib/perl5/vendor_perl/5.20.0/DNSCheck.pm line 51.
> Compilation failed in require at /usr/pkg/bin/dnscheck line 42.
> BEGIN failed--compilation aborted at /usr/pkg/bin/dnscheck line 42.
>
> > How-To-Repeat:
> make net/dnscheck, install and run as is.
> > Fix:
> make devel/p5-List-MoreUtils, install and run dnscheck again.