Re: devel/xulrunner192

[Thomas Klausner <tk%giga.or.at@localhost>]

Hi Sergio!

pkgsrc-bugs is intended only for the mails generated by GNATS, not for
other traffic. Please either file a bug report or discuss the patch on
pkgsrc-users.

On Thu, Jan 29, 2015 at 10:47:06AM -0200, sergio de Almeida Lenzi wrote:
> @@ -12,6 +12,8 @@ LICENSE=	mpl-1.1
>  
>  MOZILLA_DIR=	# empty
>  
> +PKG_OPTIONS.xulrunner=	gnome
> +

This should not be in the patch.

> xulrunner/installer/mozilla-gtkmozembed-embedding.pc.in
> diff -up ./PLIST.orig ./PLIST
> --- ./PLIST.orig	2012-02-22 09:00:06.000000000 -0200
> +++ ./PLIST	2015-01-26 15:44:39.000000000 -0200
> @@ -1,22 +1,34 @@
> -@comment $NetBSD: PLIST,v 1.3 2012/02/22 11:00:06 obache Exp $
> +@comment $NetBSD$
>  bin/xulrunner192
> -${PLIST.jit}include/xulrunner192/Allocator.h
> -${PLIST.jit}include/xulrunner192/Assembler.h
> -${PLIST.jit}include/xulrunner192/CodeAlloc.h
> -${PLIST.jit}include/xulrunner192/Containers.h
> -${PLIST.jit}include/xulrunner192/Fragmento.h
> +include/xulrunner192/Allocator.h
> +include/xulrunner192/Assembler.h
> +include/xulrunner192/CodeAlloc.h
> +include/xulrunner192/Containers.h
> +include/xulrunner192/Fragmento.h

These changes should also not be there. Please review the PLIST diff;
actually I would assume no changes here.

> diff -up ./mozilla-common.mk.orig ./mozilla-common.mk
> --- ./mozilla-common.mk.orig	2014-05-09 04:37:04.000000000 -0300
> +++ ./mozilla-common.mk	2015-01-26 15:44:39.000000000 -0200
> @@ -22,14 +22,15 @@ CONFIGURE_ARGS+=	--enable-optimize=-O2 -
>  CONFIGURE_ARGS+=	--disable-javaxpcom
>  CONFIGURE_ARGS+=	--enable-default-toolkit=cairo-gtk2
>  CONFIGURE_ARGS+=	--enable-svg --enable-mathml
> -CONFIGURE_ARGS+=	--enable-system-cairo
> -CONFIGURE_ARGS+=	--with-system-jpeg
> -CONFIGURE_ARGS+=	--with-system-zlib --with-system-bz2
> -CONFIGURE_ARGS+=	--with-system-libevent=${BUILDLINK_PREFIX.libevent}
> -CONFIGURE_ARGS+=	--enable-system-sqlite
> +#CONFIGURE_ARGS+=	--enable-system-cairo
> +#CONFIGURE_ARGS+=	--with-system-jpeg
> +#CONFIGURE_ARGS+=	--with-system-zlib --with-system-bz2
> +#CONFIGURE_ARGS+=	--with-system-libevent=${BUILDLINK_PREFIX.libevent}
> +#CONFIGURE_ARGS+=	--enable-system-sqlite
>  CONFIGURE_ARGS+=	--disable-crashreporter
>  CONFIGURE_ARGS+=	--disable-libnotify
>  CONFIGURE_ARGS+=	--disable-necko-wifi
> +CONFIGURE_ARGS+=	--enable-tree-freetype
>  CONFIGURE_ARGS+=	--enable-chrome-format=flat

We don't want to use the included libraries because then we have to
fix lots of packages for every compilation issue or security patch.
Please try to make a patch that works against the installed freetype
etc. libraries instead.

> +.include "../../net/wget/buildlink3.mk"

This is just wrong. wget does not install a library, so it does not
need a bl3.mk file, and it does not have one.

If this really depends on wget, then use a BUILD_DEPENDS or DEPENDS
instead.

Cheers,
 Thomas