Re: pkg/49590: net/samba fails to build on Mac OS X 10.10 (with fix)

[youri <youri.mout%gmail.com@localhost>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

We should specify that only Mac OS X >= 10.7 so Darwin >= 11.

.if ${OPSYS} != "Darwin"

can be replaced with

.if !empty(MACHINE_PLATFORM:MDarwin-1[1-9].*)

On 20/01/15 19:45, youri.mout%gmail.com@localhost wrote:
>> Number:         49590 Category:       pkg Synopsis:
>> net/samba fails to build on Mac OS X 10.10 (with fix) 
>> Confidential:   no Severity:       serious Priority:       high 
>> Responsible:    pkg-manager State:          open Class:
>> sw-bug Submitter-Id:   net Arrival-Date:   Tue Jan 20 18:45:00
>> +0000 2015 Originator:     Youri Mouton Release:        current 
>> Organization: Environment:
> Darwin mac.local 14.0.0 Darwin Kernel Version 14.0.0: Fri Sep 19
> 00:26:44 PDT 2014; root:xnu-2782.1.97~2/RELEASE_X86_64 x86_64
>> Description:
> net/samba's default options contain 'ads' which uses the kerberos
> option that makes the build fail on OS X 10.10.
>> How-To-Repeat:
> 
>> Fix:
> Make ads not a suggested option on Darwin.
> 
> diff --git a/net/samba/options.mk b/net/samba/options.mk index
> ce9c487..af0ecab 100644 --- a/net/samba/options.mk +++
> b/net/samba/options.mk @@ -9,7 +9,11 @@ # PKG_OPTIONS_VAR=
> PKG_OPTIONS.samba PKG_SUPPORTED_OPTIONS= ads cups fam ldap pam
> winbind -PKG_SUGGESTED_OPTIONS= ads ldap pam winbind 
> +PKG_SUGGESTED_OPTIONS= ldap pam winbind + +.if ${OPSYS} !=
> "Darwin" +PKG_SUGGESTED_OPTIONS+=        ads +.endif
> 
-----BEGIN PGP SIGNATURE-----

iQIcBAEBAgAGBQJUvqjoAAoJEGoJXMYtmcj3AEkP/1WZ+FfHYwbVgph1t9LH41Rj
+xDp5mqzbQA2+NX0TzKjst45krJNsMisqGXbk2h+hJNMk5UzQfTBlWX81lIz9v/5
t03Tuv3mgS7XVKAJXdtOsMHKkh5jjzjzVceickDHRk14Sn/Fyu86NmpTX/pbYPuf
5ZjWw11jGbew78lb0a8g2whaciB//HEe2H6pVrP+ofvNpC4Icm/Ca/75sU2A5qE4
T7HEyFvgNU5669nF4tNN5hl9JlwnytHhodHSB2Psbnro9D+j6jL3AMHgxgWxR0A8
i8LZvD6dEHQjvx10oYi2usCZMEsTs5PqK1A9jRtXsorlnm9aGS+UpKEWxOjcqXE2
WrRHFmEAPi/utLzA5GtelNcnvIp8LJF8YymMPobNzPD22e3/TJcbb0WDzIyKdZVk
aYxSD9MnB+4G1iL3zhhCVXJP7lu5k12aqhRtdFLL8iBw+6Iu5ymh9BLMooMB+zcN
ME//dsfzlEcxUtdLHmdZb1W0xyejawexR+XrzySX+qLpnVhTmvwvg9X0hohumlzI
ahWWfdcE8gF3h/ThWKgP9xjWdIBwcNEgkQiL/DzdULsuWEtMDC0l12Z6Vb592rQE
Gc1+yrobDdNm+T9vbAi4QSxVINQ+IJ1+fZfj7vOTvxApmMgJfMDNsrXgcNy20P+i
WcQQzqoMHKRSejafyv3C
=v0j8
-----END PGP SIGNATURE-----