pkg/49382: cad/xcircuit fails to build

[pr%i3enedek.neomailbox.net@localhost]

>Number:         49382
>Category:       pkg
>Synopsis:       cad/xcircuit fails to build
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 11 19:50:00 +0000 2014
>Originator:     Ben Gergely
>Release:        current
>Organization:
>Environment:
NetBSD 7.99.1 i386
>Description:
Xcircuit seems to have some issue around building to do with the tcl wrapper, I've patched up the bits that fail to compile and updated the make file to fetch version 3.7.57 but cant figure out fixing Makefile.in.

The install phase problem is to do with making the binary and $(INTERP_PATH):

741         $(MAKE) lib/tcl/xcircuit${SHDLIB_EXT}
742         $(MAKE) lib/$(INTERP_PATH)/$(WRAPPER_SH)
743         $(MAKE) lib/$(INTERP_PATH)/$(WRAPPER_INIT)
744         $(MAKE) xcircexec$(EXEEXT)

maybe replacing INTERP_PATH with the path e.g. tcl as in line 741 might work in some places

dropping tcl as the build target creates a working binary, but with a loss of functionality
BUILD_TARGET=   tcl
INSTALL_TARGET= install-tcl

The compile time issues are also tcl related.

>How-To-Repeat:
cd /usr/pkgsrc/cad/xcircuit ; make
>Fix:
don't build with tcl with a loss of functionality:

BUILD_TARGET=   tcl
INSTALL_TARGET= install-tcl

if also bumping the version to xcircuit-3.7.57 (might as well) apply these patches:
$NetBSD$

--- menucalls.c.orig    2013-01-01 17:24:44.000000000 +0000
+++ menucalls.c
@@ -62,9 +62,7 @@ extern Tcl_Interp *xcinterp;
 /* Local Variable definitions                                          */
 /*----------------------------------------------------------------------*/
 
-#ifdef TCL_WRAPPER
 u_short *fontnumbers;
-#endif
 u_char nfontnumbers;
 
 /*----------------------------------------------*/
$NetBSD$

--- xcircuit.c.orig     2013-01-01 17:24:44.000000000 +0000
+++ xcircuit.c
@@ -114,9 +114,7 @@ xcIntervalId printtime_id;
 short beeper;
 short fontcount;
 fontinfo *fonts;
-#ifdef TCL_WRAPPER
 short   popups;      /* total number of popup widgets on the screen */
-#endif
 
 /*----------------------------------------------------------------------*/
 /* Externally defined variables                                               */