pkg/49209: databases/phppgadmin package is missing lots of stuff

[timshel%shels.net@localhost]

>Number:         49209
>Category:       pkg
>Synopsis:       databases/phppgadmin package is missing lots of stuff
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 17 02:40:00 +0000 2014
>Originator:     Timshel Knoll-Miller
>Release:        pkgsrc-2014Q2 (same as HEAD for this package)
>Organization:
>Environment:
NetBSD eomer 6.1.4 NetBSD 6.1.4 (GENERIC) amd64
>Description:
databases/phppgadmin is missing a heap of resource files (images, css, 
javascripts) due to an issue with its use of 'find' arguments within the 
Makefile. It passes '-o "*.gif" -o "*.ico"' to the "find" command, which should 
be: '-o -name "*.gif" -o -name "*.ico"'. 
>How-To-Repeat:
Install phppgadmin and set up virtual host as instructed. On visiting the site, 
images & css will not load and site will be unusable as JavaScript has not 
loaded as this is all missing from the package.
>Fix:
Patch to Makefile and PLIST:


$NetBSD$

--- databases/phppgadmin/Makefile.orig  2014-06-14 15:21:46.000000000 +0000
+++ databases/phppgadmin/Makefile
@@ -53,7 +53,7 @@ do-install:
        done
 # data:
        cd ${WRKSRC}; \
-       for f in $$(find . -name "*.sql" -o -name "*.txt" -o -name "*.css" -o 
-name "*.js" -o -name "*.png" -o "*.gif" -o "*.ico"); do \
+       for f in $$(find . -name "*.sql" -o -name "*.txt" -o -name "*.css" -o 
-name "*.js" -o -name "*.png" -o -name "*.gif" -o -name "*.ico"); do \
                ${INSTALL_DATA} $$f ${DESTDIR}${PHPPGBASE}/$$f; \
        done
 
--- databases/phppgadmin/PLIST.orig     2014-06-15 01:21:46.000000000 +1000
+++ databases/phppgadmin/PLIST  2014-09-17 12:28:22.000000000 +1000
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.16 2014/06/14 15:21:46 asau Exp $
+@comment $NetBSD$
 share/doc/phppgadmin/CREDITS
 share/doc/phppgadmin/DEVELOPERS
 share/doc/phppgadmin/FAQ
@@ -43,6 +43,7 @@
 share/phppgadmin/display.php
 share/phppgadmin/domains.php
 share/phppgadmin/fulltext.php
+share/phppgadmin/functions.js
 share/phppgadmin/functions.php
 share/phppgadmin/groups.php
 share/phppgadmin/help.php
@@ -56,10 +57,155 @@
 share/phppgadmin/help/PostgresDoc91.php
 share/phppgadmin/help/PostgresDoc92.php
 share/phppgadmin/history.php
+share/phppgadmin/images/themes/cappuccino/Lminus.png
+share/phppgadmin/images/themes/cappuccino/Lplus.png
+share/phppgadmin/images/themes/cappuccino/Tminus.png
+share/phppgadmin/images/themes/cappuccino/Tplus.png
+share/phppgadmin/images/themes/cappuccino/inputbckg.png
+share/phppgadmin/images/themes/cappuccino/openListe.png
+share/phppgadmin/images/themes/cappuccino/title.png
+share/phppgadmin/images/themes/default/AddArguments.png
+share/phppgadmin/images/themes/default/Admin.png
+share/phppgadmin/images/themes/default/Aggregate.png
+share/phppgadmin/images/themes/default/Aggregates.png
+share/phppgadmin/images/themes/default/AllUsers.png
+share/phppgadmin/images/themes/default/AvailableReplicationSet.png
+share/phppgadmin/images/themes/default/AvailableSubscription.png
+share/phppgadmin/images/themes/default/Backup.png
+share/phppgadmin/images/themes/default/Cast.png
+share/phppgadmin/images/themes/default/Casts.png
+share/phppgadmin/images/themes/default/CheckConstraint.png
+share/phppgadmin/images/themes/default/Cluster.png
+share/phppgadmin/images/themes/default/Column.png
+share/phppgadmin/images/themes/default/Columns.png
+share/phppgadmin/images/themes/default/Constraints.png
+share/phppgadmin/images/themes/default/Conversion.png
+share/phppgadmin/images/themes/default/Conversions.png
+share/phppgadmin/images/themes/default/Copy.png
+share/phppgadmin/images/themes/default/CorruptedDatabase.png
+share/phppgadmin/images/themes/default/Cut.png
+share/phppgadmin/images/themes/default/Database.png
+share/phppgadmin/images/themes/default/Databases.png
+share/phppgadmin/images/themes/default/Definition.png
+share/phppgadmin/images/themes/default/Delete.png
+share/phppgadmin/images/themes/default/DisabledJob.png
+share/phppgadmin/images/themes/default/DisconnectedDatabase.png
+share/phppgadmin/images/themes/default/DisconnectedServer.png
+share/phppgadmin/images/themes/default/Domain.png
+share/phppgadmin/images/themes/default/Domains.png
+share/phppgadmin/images/themes/default/EnableArgument.png
+share/phppgadmin/images/themes/default/Erase.png
+share/phppgadmin/images/themes/default/Execute.png
+share/phppgadmin/images/themes/default/ExecuteSave.png
+share/phppgadmin/images/themes/default/Explain.png
+share/phppgadmin/images/themes/default/Export.png
+share/phppgadmin/images/themes/default/Favicon.ico
+share/phppgadmin/images/themes/default/Filter.png
+share/phppgadmin/images/themes/default/ForeignKey.png
+share/phppgadmin/images/themes/default/Fts.png
+share/phppgadmin/images/themes/default/FtsCfg.png
+share/phppgadmin/images/themes/default/FtsDict.png
+share/phppgadmin/images/themes/default/FtsParser.png
+share/phppgadmin/images/themes/default/Function.png
+share/phppgadmin/images/themes/default/Functions.png
+share/phppgadmin/images/themes/default/GurusHint.png
+share/phppgadmin/images/themes/default/Help.png
+share/phppgadmin/images/themes/default/Histories.png
+share/phppgadmin/images/themes/default/History.png
+share/phppgadmin/images/themes/default/I.png
+share/phppgadmin/images/themes/default/Import.png
+share/phppgadmin/images/themes/default/Index.png
+share/phppgadmin/images/themes/default/Indexes.png
+share/phppgadmin/images/themes/default/Introduction.png
+share/phppgadmin/images/themes/default/Job.png
+share/phppgadmin/images/themes/default/Jobs.png
+share/phppgadmin/images/themes/default/Key.png
+share/phppgadmin/images/themes/default/L.png
+share/phppgadmin/images/themes/default/Language.png
+share/phppgadmin/images/themes/default/Languages.png
+share/phppgadmin/images/themes/default/Listen.png
+share/phppgadmin/images/themes/default/Listens.png
+share/phppgadmin/images/themes/default/Lminus.png
+share/phppgadmin/images/themes/default/Loading.gif
+share/phppgadmin/images/themes/default/LowerArgument.png
+share/phppgadmin/images/themes/default/Lplus.png
+share/phppgadmin/images/themes/default/Node.png
+share/phppgadmin/images/themes/default/Nodes.png
+share/phppgadmin/images/themes/default/ObjectNotFound.png
+share/phppgadmin/images/themes/default/OfferedReplicationSet.png
+share/phppgadmin/images/themes/default/OfferedSubscription.png
+share/phppgadmin/images/themes/default/Open.png
+share/phppgadmin/images/themes/default/Operator.png
+share/phppgadmin/images/themes/default/OperatorClass.png
+share/phppgadmin/images/themes/default/OperatorClasses.png
+share/phppgadmin/images/themes/default/Operators.png
+share/phppgadmin/images/themes/default/Paste.png
+share/phppgadmin/images/themes/default/Path.png
+share/phppgadmin/images/themes/default/Paths.png
+share/phppgadmin/images/themes/default/PrimaryKey.png
+share/phppgadmin/images/themes/default/Privileges.png
+share/phppgadmin/images/themes/default/Processes.png
+share/phppgadmin/images/themes/default/Property.png
+share/phppgadmin/images/themes/default/RaiseArgument.png
+share/phppgadmin/images/themes/default/Record.png
+share/phppgadmin/images/themes/default/Records.png
+share/phppgadmin/images/themes/default/Redo.png
+share/phppgadmin/images/themes/default/Refresh.png
+share/phppgadmin/images/themes/default/RemoveArgument.png
+share/phppgadmin/images/themes/default/Replication.png
+share/phppgadmin/images/themes/default/ReplicationSets.png
+share/phppgadmin/images/themes/default/Restore.png
+share/phppgadmin/images/themes/default/Roles.png
+share/phppgadmin/images/themes/default/Rule.png
+share/phppgadmin/images/themes/default/Rules.png
+share/phppgadmin/images/themes/default/Save.png
+share/phppgadmin/images/themes/default/Schedule.png
+share/phppgadmin/images/themes/default/Schedules.png
+share/phppgadmin/images/themes/default/Schema.png
+share/phppgadmin/images/themes/default/Schemas.png
+share/phppgadmin/images/themes/default/Search.png
+share/phppgadmin/images/themes/default/Sequence.png
+share/phppgadmin/images/themes/default/Sequences.png
+share/phppgadmin/images/themes/default/Server.png
+share/phppgadmin/images/themes/default/Servers.png
+share/phppgadmin/images/themes/default/SqlEditor.png
+share/phppgadmin/images/themes/default/Statistics.png
+share/phppgadmin/images/themes/default/Step.png
+share/phppgadmin/images/themes/default/Steps.png
+share/phppgadmin/images/themes/default/Stop.png
+share/phppgadmin/images/themes/default/Subscriptions.png
+share/phppgadmin/images/themes/default/T.png
+share/phppgadmin/images/themes/default/Table.png
+share/phppgadmin/images/themes/default/Tables.png
+share/phppgadmin/images/themes/default/Tablespace.png
+share/phppgadmin/images/themes/default/Tablespaces.png
+share/phppgadmin/images/themes/default/Tminus.png
+share/phppgadmin/images/themes/default/Tplus.png
+share/phppgadmin/images/themes/default/Trigger.png
+share/phppgadmin/images/themes/default/TriggerFunction.png
+share/phppgadmin/images/themes/default/TriggerFunctions.png
+share/phppgadmin/images/themes/default/Triggers.png
+share/phppgadmin/images/themes/default/Type.png
+share/phppgadmin/images/themes/default/Types.png
+share/phppgadmin/images/themes/default/Undo.png
+share/phppgadmin/images/themes/default/UniqueConstraint.png
+share/phppgadmin/images/themes/default/User.png
+share/phppgadmin/images/themes/default/UserGroup.png
+share/phppgadmin/images/themes/default/UserGroups.png
+share/phppgadmin/images/themes/default/Users.png
+share/phppgadmin/images/themes/default/Variables.png
+share/phppgadmin/images/themes/default/View.png
+share/phppgadmin/images/themes/default/Views.png
+share/phppgadmin/images/themes/default/blank.png
+share/phppgadmin/images/themes/default/title.png
 share/phppgadmin/index.php
+share/phppgadmin/indexes.js
 share/phppgadmin/indexes.php
 share/phppgadmin/info.php
 share/phppgadmin/intro.php
+share/phppgadmin/js/ac_insert_row.js
+share/phppgadmin/js/database.js
+share/phppgadmin/js/display.js
 share/phppgadmin/lang/afrikaans.php
 share/phppgadmin/lang/arabic.php
 share/phppgadmin/lang/catalan.php
@@ -128,14 +274,19 @@
 share/phppgadmin/libraries/adodb/lang/adodb-sv.inc.php
 share/phppgadmin/libraries/adodb/lang/adodb-uk1251.inc.php
 share/phppgadmin/libraries/adodb/lang/adodb_th.inc.php
+share/phppgadmin/libraries/adodb/license.txt
+share/phppgadmin/libraries/adodb/readme.txt
 share/phppgadmin/libraries/adodb/toexport.inc.php
 share/phppgadmin/libraries/adodb/tohtml.inc.php
 share/phppgadmin/libraries/decorator.inc.php
 share/phppgadmin/libraries/errorhandler.inc.php
 share/phppgadmin/libraries/highlight.php
+share/phppgadmin/libraries/js/jquery.js
 share/phppgadmin/libraries/lib.inc.php
+share/phppgadmin/links.js
 share/phppgadmin/login.php
 share/phppgadmin/logout.php
+share/phppgadmin/multiactionform.js
 share/phppgadmin/opclasses.php
 share/phppgadmin/operators.php
 share/phppgadmin/plugin.php
@@ -143,6 +294,8 @@
 share/phppgadmin/plugins/GuiControl/plugin.php
 share/phppgadmin/plugins/Report/classes/Reports.php
 share/phppgadmin/plugins/Report/conf/config.inc.php
+share/phppgadmin/plugins/Report/images/Report.png
+share/phppgadmin/plugins/Report/images/Reports.png
 share/phppgadmin/plugins/Report/lang/afrikaans.php
 share/phppgadmin/plugins/Report/lang/arabic.php
 share/phppgadmin/plugins/Report/lang/catalan.php
@@ -175,8 +328,10 @@
 share/phppgadmin/plugins/Report/lang/turkish.php
 share/phppgadmin/plugins/Report/lang/ukrainian.php
 share/phppgadmin/plugins/Report/plugin.php
+share/phppgadmin/plugins/Report/sql/reports-pgsql.sql
 share/phppgadmin/privileges.php
 share/phppgadmin/redirect.php
+share/phppgadmin/robots.txt
 share/phppgadmin/roles.php
 share/phppgadmin/rules.php
 share/phppgadmin/schemas.php
@@ -184,22 +339,19 @@
 share/phppgadmin/servers.php
 share/phppgadmin/sql.php
 share/phppgadmin/sqledit.php
+share/phppgadmin/tables.js
 share/phppgadmin/tables.php
 share/phppgadmin/tablespaces.php
 share/phppgadmin/tblproperties.php
+share/phppgadmin/themes/cappuccino/global.css
+share/phppgadmin/themes/default/global.css
+share/phppgadmin/themes/global.css
+share/phppgadmin/themes/gotar/global.css
 share/phppgadmin/themes/themes.php
 share/phppgadmin/triggers.php
 share/phppgadmin/types.php
 share/phppgadmin/users.php
 share/phppgadmin/viewproperties.php
 share/phppgadmin/views.php
-@pkgdir share/phppgadmin/xloadtree
-@pkgdir share/phppgadmin/themes/gotar
-@pkgdir share/phppgadmin/themes/default
-@pkgdir share/phppgadmin/themes/cappuccino
-@pkgdir share/phppgadmin/plugins/Report/sql
-@pkgdir share/phppgadmin/plugins/Report/images
-@pkgdir share/phppgadmin/libraries/js
-@pkgdir share/phppgadmin/js
-@pkgdir share/phppgadmin/images/themes/default
-@pkgdir share/phppgadmin/images/themes/cappuccino
+share/phppgadmin/xloadtree/xloadtree2.js
+share/phppgadmin/xloadtree/xtree2.js